Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read Me First: Close anchor tag in code example #3073

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Read Me First: Close anchor tag in code example #3073

merged 1 commit into from
Aug 6, 2024

Conversation

mathildebuenerd
Copy link
Contributor

@mathildebuenerd mathildebuenerd commented Jul 31, 2024 •
edited by daniel-montalvo
Loading

In the Read me first page, section "Principle 2: ARIA Can Both Cloak and Enhance, Creating Both Power and Danger", the anchor tag is not closed in the third example.

Before:

<li><a href="uri1">nav link 1</li>
<li><a href="uri2">nav link 2</li>

After:

<li><a href="uri1">nav link 1</a></li>
<li><a href="uri2">nav link 2</a></li>

WAI Preview Link (Last built on Wed, 31 Jul 2024 08:17:27 GMT).

@daniel-montalvo daniel-montalvo mentioned this pull request Jul 31, 2024
Closed
mcking65
mcking65 approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@mcking65 mcking65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mathildebuenerd, good catch! Thank you for the fix. Looks good.

@mcking65 mcking65 changed the title Close anchor tag in code example Read Me First: Close anchor tag in code example Aug 6, 2024
@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Feedback Issue raised by or for collecting input from people outside APG task force Inaccuracy Incorrect statement in prose (not a code bug) labels Aug 6, 2024
@mcking65 mcking65 merged commit 2d60c41 into w3c:main Aug 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcking65 mcking65 mcking65 approved these changes

Assignees
No one assigned
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Feedback Issue raised by or for collecting input from people outside APG task force Inaccuracy Incorrect statement in prose (not a code bug)
Projects
None yet
Milestone
2024-09-10 Publication Pull Requests
Development

Successfully merging this pull request may close these issues.
2 participants
@mathildebuenerd @mcking65