Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix path to ratings star images #2705

Closed
wants to merge 1 commit into from
Closed

Conversation

frozenzia
Copy link
Contributor

@frozenzia frozenzia commented May 24, 2023

This has not been tested in any way by myself, and it's possible there's a problem with "backing up" the directory tree that much, but as best as I can tell, this should fix these paths.


WAI Preview Link (Last built on Wed, 24 May 2023 08:33:37 GMT).

@css-meeting-bot
Copy link
Member

The ARIA Authoring Practices (APG) Task Force just discussed Fix path to ratings star images.

The full IRC log of that discussion <jugglinmike> Subtopic: Fix path to ratings star images
<jugglinmike> github: https://github.com//pull/2705
<jugglinmike> Matt_King: I think this won't work because it assumes the content repository is the same as the build repository
<jugglinmike> howard-e: As far as I know, this will result in a different path resolution if rendered for the live site
<jugglinmike> Matt_King: I believe there's an issue related to this in the other repository
<jugglinmike> howard-e: perhaps https://github.com//issues/2628
<jugglinmike> howard-e: I'll follow up on the issue to help the contributor understand why we're going to close this

@howard-e
Copy link
Contributor

howard-e commented May 31, 2023

@frozenzia thanks for the PR! Unfortunately, this may not solve the overall issue.

The change here assumes that this path only affects the example when deployed to the APG website but this would negatively affect the standalone example in this repository.

Some general background on the issue is that the structure of this repository's content cannot be maintained by the underlying Jekyll build system used to organize the various assets, files and styles when deploying the the WAI APG website. In this instance, the feedDisplay.js, feed-display.html and related assets were outliers from the expected pattern and couldn't be packaged as expected which results in improperly defined or missing asset paths in cases like this.

Additional context:

Some time has been spent looking into how we can work around having that build system accept the files packaged together in a more predictable manner, but this PR does indicate a quicker fix can be done for the moment. w3c/wai-aria-practices holds the code that transforms, moves and generates the APG website "package" to be deployed through the WAI website. So I've gone ahead and submitted w3c/wai-aria-practices#224 which includes a transform to account for this case. We'd recommend closing this PR with that as the alternative.

@mcking65
Copy link
Contributor

mcking65 commented Jun 5, 2023

Closing per above comment and need for a different solution as described in #2628.

@mcking65 mcking65 closed this Jun 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants