Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update apg 1.2 with latest from master branch #1583

Merged
merged 38 commits into from
Oct 25, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
38 commits
Select commit Hold shift + click to select a range
c57c012
Infrastructure: Trigger regression testing for lock file changes (pul…
nschonni Sep 8, 2020
32ca9d3
Infrastructure: Add support for opening examples in CodePen (pull #1110)
spectranaut Sep 15, 2020
7e78d9a
Infrastructure: Move Stylelint to GitHub action and fix broken config…
nschonni Sep 25, 2020
8f0b40b
Infrastructure: Switch regression test to GitHub Actions (pull #1515)
nschonni Sep 25, 2020
3c853b8
Infrastructure: Swap to GitHub Action for JS linting (pull #1501)
nschonni Sep 29, 2020
7dee05d
Infrastructure: Create Dependabot config file (pull #1505)
nschonni Sep 29, 2020
2233e5c
Infrastructure: Move Regression coverage to PR comment (pull #1517)
nschonni Sep 29, 2020
b866f7c
Multiple Pages: fix Broken links (pull #1535)
nschonni Sep 29, 2020
b4a99c4
Infrastructure: Bump cspell package from 4.0.56 to 4.1.0 (pull #1544)
dependabot[bot] Sep 30, 2020
9d19d94
Infrastructure: Bump actions/github-script package from 0.9.0 to v3 (…
dependabot[bot] Sep 30, 2020
7c3b3cc
Fix links to Carousel Example with Buttons for Slide Control (pull #1…
spectranaut Sep 30, 2020
908af41
Infrastructure: Convert spellcheck to GitHub Action making it require…
nschonni Sep 30, 2020
9489ed5
Infrastructure: Bump stylelint package from 13.3.2 to 13.7.2 (pull #1…
dependabot[bot] Sep 30, 2020
04c8d65
Infrastructure: Bump eslint package from 6.8.0 to 7.10.0 (pull #1541)
dependabot[bot] Sep 30, 2020
cc5f061
Infrastructure: Bump lint-staged from 10.1.3 to 10.4.0 (pul #1540)
dependabot[bot] Sep 30, 2020
4d85e90
Infrastructure: Bump husky package from 4.2.5 to 4.3.0 (pull #1543)
dependabot[bot] Sep 30, 2020
bdaa4c8
Infrastructure: Stop linting Deleted Section Archive (pull #1550)
nschonni Oct 12, 2020
82a160d
Infrastructure: Adjust GitHub Action key names (pull #1549)
nschonni Oct 12, 2020
51203bd
Infrastructure: Disable push builds for Dependabot (pull #1551)
nschonni Oct 12, 2020
74fd381
Infrastructure: Update actions/setup-node requirement to v2.1.2 (pull…
dependabot[bot] Oct 12, 2020
7a8f135
Infrastructure: Bump geckodriver from 1.19.1 to 1.20.0 (pull #1538)
dependabot[bot] Oct 12, 2020
2cf2233
Infrastructure: Bump ava from 3.10.1 to 3.13.0 (pull #1537)
dependabot[bot] Oct 12, 2020
78bb9a0
Infrastructure: Do not spell check idrefs in aria attribute values (p…
jnurthen Oct 12, 2020
303191d
Infrastructure: Add Prettier Stylelint config (pull #1554)
nschonni Oct 21, 2020
d4e3284
Infrastructure: Add Prettier ESLint config (pull #1553)
nschonni Oct 21, 2020
cdf213f
Infrastructure: Bump cspell package from 4.1.0 to 4.1.2 (pull #1574)
dependabot[bot] Oct 21, 2020
8931a62
Infrastructure: Bump eslint package from 7.10.0 to 7.11.0 (pull #1565)
dependabot[bot] Oct 21, 2020
81c92c3
Infrastructure: Bump lint-staged package from 10.4.0 to 10.4.2 (pull …
dependabot[bot] Oct 21, 2020
6485d4c
Infrastructure: Switch HTML linting to GitHub Actions (pull #1523)
nschonni Oct 21, 2020
a9bb774
Infrastructure: Update vnujar filtering to restore ignoring no alt on…
spectranaut Oct 22, 2020
c4d8d14
Infrastructure: Format PR comments containing regression coverage rep…
spectranaut Oct 22, 2020
89a5abf
Infrastructure: add Ava ESLint plug-in with recommended rules (pull #…
nschonni Oct 23, 2020
c2ee25e
Infrastructure: Bump eslint-config-prettier package from 6.12.0 to 6.…
dependabot[bot] Oct 23, 2020
19c745a
Accessible Name Guidance by Role Section: change marquee name from re…
smhigley Oct 23, 2020
74a9365
Update apg-1.2 branch with latest commits from master branch.
mcking65 Oct 23, 2020
61cd456
fix spelling errors
mcking65 Oct 23, 2020
1b365ad
Infrastructure: Do not test coding template and fix spelling of depre…
nschonni Oct 25, 2020
e701d9b
Merge latest changes from master into branch for updating apg-1.2
mcking65 Oct 25, 2020
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "eslint:recommended",
"extends": ["eslint:recommended", "plugin:prettier/recommended"],
"env": {
"browser": true
},
Expand Down
14 changes: 14 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,14 @@
version: 2
updates:
- package-ecosystem: npm
directory: "/"
schedule:
interval: daily
time: "10:00"
open-pull-requests-limit: 10
- package-ecosystem: github-actions
directory: "/"
schedule:
interval: daily
time: "10:00"
open-pull-requests-limit: 10
60 changes: 60 additions & 0 deletions .github/workflows/coverage-report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
name: Regression Tests Coverage Report

on:
pull_request_target:
paths:
- "examples/**"
- "test/**"
- "!examples/landmarks/**"

jobs:
report:
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v2
with:
ref: refs/pull/${{ github.event.pull_request.number }}/head

- name: Install dependencies
run: npm ci

- name: Run coverage report
run: |
node test/util/report.js >> coverage.log || true

- name: Comment on PR
uses: actions/github-script@v3
with:
github-token: ${{secrets.GITHUB_TOKEN}}
script: |
const fs = require('fs');
const commentBody = fs.readFileSync('coverage.log', 'utf8');

if (commentBody.length === 0) {
return
}
// Get the existing comments.
const {data: comments} = await github.issues.listComments({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.payload.number,
})
// Find any comment already made by the bot.
const botComment = comments.find(comment => comment.user.id === 41898282)

if (botComment) {
await github.issues.updateComment({
owner: context.repo.owner,
repo: context.repo.repo,
comment_id: botComment.id,
body: commentBody
})
} else {
await github.issues.createComment({
owner: context.repo.owner,
repo: context.repo.repo,
issue_number: context.payload.number,
body: commentBody
})
}
16 changes: 16 additions & 0 deletions .github/workflows/cspell-problem-matcher.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
{
"problemMatcher": [
{
"owner": "cspell",
"pattern": [
{
"regexp": "^(.*):(\\d+):(\\d+)\\s+\\-\\s+(.*)$",
"file": 1,
"line": 2,
"column": 3,
"message": 4
}
]
}
]
}
40 changes: 40 additions & 0 deletions .github/workflows/lint-css.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: CSS Linting
on:
push:
branches-ignore:
- "dependabot/**"
paths:
- "package*.json"
- ".prettier*"
- ".stylelint*"
- "**/*.css"
- ".github/workflows/lint-css.yml"
- "!common/**"

pull_request:
paths:
- "package*.json"
- ".prettier*"
- ".stylelint*"
- "**/*.css"
- ".github/workflows/lint-css.yml"
- "!common/**"

jobs:
lint-css:
runs-on: ubuntu-latest

steps:
- name: Clone repository
uses: actions/checkout@v2

- name: Set up Node.js
uses: actions/setup-node@v2.1.2

- uses: xt0rted/stylelint-problem-matcher@v1

- name: Install npm dependencies
run: npm ci

- name: Stylelint
run: npm run lint:css
40 changes: 40 additions & 0 deletions .github/workflows/lint-html.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: HTML Linting
on:
push:
branches-ignore:
- "dependabot/**"
paths:
- "package*.json"
- ".vnurc"
- "aria-practices.html"
- "examples/**/*.html"
- ".github/workflows/lint-html.yml"
- ".github/workflows/vnu-jar-problem-matcher.json"

pull_request:
paths:
- "package*.json"
- ".vnurc"
- "aria-practices.html"
- "examples/**/*.html"
- ".github/workflows/lint-html.yml"
- ".github/workflows/vnu-jar-problem-matcher.json"

jobs:
lint-html:
runs-on: ubuntu-latest

steps:
- name: Clone repository
uses: actions/checkout@v2

- name: Set up Node.js
uses: actions/setup-node@v2.1.2

- name: Install npm dependencies
run: npm ci

- name: HTML Validator
run: |
echo "::add-matcher::.github/workflows/vnu-jar-problem-matcher.json"
npm run lint:html
40 changes: 40 additions & 0 deletions .github/workflows/lint-js.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,40 @@
name: JavaScript Linting
on:
push:
branches-ignore:
- "dependabot/**"
paths:
- "package*.json"
- ".prettier*"
- ".eslint*"
- "**/*.js"
- ".github/workflows/lint-js.yml"
- "!common/**"

pull_request:
paths:
- "package*.json"
- ".prettier*"
- ".eslint*"
- "**/*.js"
- ".github/workflows/lint-js.yml"
- "!common/**"

jobs:
lint-js:
runs-on: ubuntu-latest

steps:
- name: Clone repository
uses: actions/checkout@v2

# setup-node task is used without a particular version in order to load
# the ESLint problem matchers
- name: Set up Node.js
uses: actions/setup-node@v2.1.2

- name: Install npm dependencies
run: npm ci

- name: ESLint
run: npm run lint:es
59 changes: 59 additions & 0 deletions .github/workflows/regression.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,59 @@
name: Run regression tests

on:
pull_request:
paths:
- ".github/workflows/regression.yml"
- "package*.json"
- "test/**"
- "examples/**"
- "!examples/landmarks/**"
- "!examples/coding-template/**"
push:
branches-ignore:
- master
- "dependabot/**"
paths:
- ".github/workflows/regression.yml"
- "package*.json"
- "test/**"
- "examples/**"
- "!examples/landmarks/**"
- "!examples/coding-template/**"

jobs:
regression:
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
CI_NODE_INDEX: [0, 1, 2, 3, 4]

steps:
- uses: actions/checkout@v2
with:
fetch-depth: 0

- name: Set up Node.js
uses: actions/setup-node@v2.1.2

- name: Install npm dependencies
run: npm ci

- name: Run Ava on changed files in PR
run: ./scripts/regression-tests.sh
if: github.event_name == 'pull_request'
env:
COMMIT_RANGE: "origin/${{ github.base_ref }}...${{ github.sha }}"
CI_NODE_TOTAL: 5
CI_NODE_INDEX: ${{ matrix.CI_NODE_INDEX }}
TEST_WAIT_TIME: 10000

- name: Run Ava for changed files from origin branch
run: ./scripts/regression-tests.sh
if: github.event_name == 'push'
env:
COMMIT_RANGE: "origin/master...${{ github.ref }}"
CI_NODE_TOTAL: 5
CI_NODE_INDEX: ${{ matrix.CI_NODE_INDEX }}
TEST_WAIT_TIME: 10000
41 changes: 41 additions & 0 deletions .github/workflows/spelling.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,41 @@
name: Spellcheck

on:
push:
branches-ignore:
- "dependabot/**"
paths:
- "package*.json"
- "cspell.json"
- "aria-practices.html"
- "examples/**/*.html"
- ".github/workflows/cspell-problem-matcher.json"
- ".github/workflows/spelling.yml"

pull_request:
paths:
- "package*.json"
- "cspell.json"
- "aria-practices.html"
- "examples/**/*.html"
- ".github/workflows/cspell-problem-matcher.json"
- ".github/workflows/spelling.yml"

jobs:
spelling:
runs-on: ubuntu-latest

steps:
- name: Clone repository
uses: actions/checkout@v2

- name: Set up Node.js
uses: actions/setup-node@v2.1.2

- name: Install npm dependencies
run: npm ci

- name: cSpell
run: |
echo "::add-matcher::.github/workflows/cspell-problem-matcher.json"
npm run lint:spelling
17 changes: 17 additions & 0 deletions .github/workflows/vnu-jar-problem-matcher.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
{
"problemMatcher": [
{
"owner": "vnu-jar",
"pattern": [
{
"regexp": "^\"file:(.*)\":(\\d+).(\\d+)-\\d+\\.\\d+:\\s(error|warning):\\s(.*)$",
"file": 1,
"line": 2,
"column": 3,
"severity": 4,
"message": 5
}
]
}
]
}
2 changes: 2 additions & 0 deletions .prettierignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Ignore external copied w3c files
common
3 changes: 3 additions & 0 deletions .prettierrc
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
{
"singleQuote": true
}
13 changes: 11 additions & 2 deletions .stylelintrc
Original file line number Diff line number Diff line change
@@ -1,6 +1,15 @@
{
"extends": ["stylelint-config-standard", "stylelint-prettier/recommended"],
"rules": {
"media-feature-name-no-unknown": [true,
"ignoreMediaFeatureNames": ["forced-colors"] ]
"media-feature-name-no-unknown": [
true,
{
"ignoreMediaFeatureNames": [
"forced-colors"
]
}
],
"no-descending-specificity": null,
"prettier/prettier": [true, {"singleQuote": false}]
}
}
3 changes: 0 additions & 3 deletions .stylelintrc.js

This file was deleted.

Loading