-
Notifications
You must be signed in to change notification settings - Fork 361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Move Stylelint to GitHub action and fix broken config #1518
Conversation
nschonni
commented
Sep 7, 2020
•
edited
Loading
edited
- Swaps Travis for Stylelint step
- Adds the "problem matcher" so issues are commented directly on the lines in PRs
- Fix the styleline config which was in 2 files, and wasn't valid in one, so hasn't been running
Wow ... interesting. Wonder how that snuck past us.
I think a PR to fix the config and change the CI is fine. Thank you for this! I'll need a few people to look at this. @jongund, this could impact other work in progress, but I don't think in any significant way. |
The remaining issues that I didn't fix was for this rule https://stylelint.io/user-guide/rules/no-descending-specificity |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for this! If fixing all the no-descending-specificity is too much for you, then can you push a commit to ignore the rule, and add a comment and an issue?
8ff35be
to
06eef44
Compare
@spectranaut good call. I opened #1522, but couldn't add a comment in the RC file, because then it stopped reading it again 😄 . The rule is null'd again for now |
06eef44
to
b89705f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At least we have the issue :)
@spectranaut the regression tests don't even like me here |
Includes problem matcher to show inline error messages on PRs
94ceca0
to
19cc407
Compare