Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

carousel Example with buttons for slide control: Improve High Contrast Support and implementation of APG Programming Practices #1387

Merged
merged 34 commits into from
Sep 4, 2020
Merged
Show file tree
Hide file tree
Changes from 28 commits
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
886f78f
update previous next carousel example with latest features
jongund Apr 18, 2020
5e60cd9
update previous next carousel example with latest features
jongund Apr 18, 2020
85a8b2a
added test file for carousel-1-prev-next.html example
jongund Apr 18, 2020
3e2f131
added height to control block
jongund Apr 19, 2020
7df9d63
edited some of the documentation
jongund Apr 20, 2020
b5deba4
updated CSS and documentation
jongund Apr 20, 2020
3b9cc55
removed old example files
jongund Apr 20, 2020
17ef611
added link to tablist carousel example
jongund Apr 20, 2020
57f53f2
fixed liniting bug and removed old test file
jongund Apr 20, 2020
01e3635
updated checkbox options
jongund Apr 21, 2020
e661372
harmonized the example with the features of the tablist carousel example
jongund Apr 22, 2020
62cf2da
updated checkbox documentation
jongund Apr 28, 2020
008974a
Merge branch 'master' into update-carousel-previous-next
jongund May 6, 2020
04a839f
merged in changes to master and added use strict
jongund Jul 6, 2020
1b6d807
Merge branch 'master' into update-carousel-previous-next
jongund Jul 14, 2020
dd391bc
Merge branch 'master' into update-carousel-previous-next
jongund Jul 20, 2020
a456137
Merge branch 'master' into update-carousel-previous-next
mcking65 Aug 7, 2020
eec5798
Merge branch 'master' into update-carousel-previous-next
mcking65 Aug 19, 2020
b810067
Minor revision to title for consistency
mcking65 Aug 19, 2020
71ed009
Editorial revision to link and description for tabbed carousel
mcking65 Aug 19, 2020
a678ea6
Editorial revision to description
mcking65 Aug 19, 2020
1d0bac2
Remove q elements that are not used for semantic quote
mcking65 Aug 19, 2020
d2520dc
Minor editorial revisions to accessibility features
mcking65 Aug 19, 2020
b4e45e8
Merge branch 'master' into update-carousel-previous-next
jongund Aug 21, 2020
6332e2f
cleaned up rotation control code
jongund Aug 21, 2020
d206999
Merge branch 'master' into update-carousel-previous-next
jongund Aug 22, 2020
b4d9d11
improved naming of one property and event handler
jongund Aug 22, 2020
9baeb49
Editorial nits fixed in both carousel-1 and carousel-2
carmacleod Aug 25, 2020
8312c64
Merge branch 'master' into update-carousel-previous-next
jongund Aug 26, 2020
85ebb92
Updated documentation for rotation control
jongund Aug 26, 2020
9e68d9c
added an edit to documentation for the tablist carousel
jongund Aug 26, 2020
3413732
updated documentation
jongund Aug 26, 2020
bdfee75
updated documentation
jongund Aug 26, 2020
8a3f9d6
Merge branch 'master' into update-carousel-previous-next
mcking65 Sep 4, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view

Large diffs are not rendered by default.

10 changes: 5 additions & 5 deletions examples/carousel/carousel-2-tablist.html
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ <h3>
</h3>

<div>
<p><span class="contrast">8 pm Sunday, March 8, on TV: Sneak peak at the final season.</span></p>
<p><span class="contrast">8 pm Sunday, March 8, on TV: Sneak peek at the final season.</span></p>
</div>
</div> <!-- .carousel-caption -->
</div> <!-- .item -->
Expand Down Expand Up @@ -373,7 +373,7 @@ <h3>Controlling Automatic Slide Rotation</h3>
<ul>
<li>The rotation control button is the first element in the screen reader reading order.</li>
<li>The rotation control button is always visible so it is available to all users whether they are interacting via a mouse, keyboard, assistive technology, or touch.</li>
<li>If the carousel is rotating, its accessible name is <q>Stop Automatic Slide Show</q>, informing screen reader users that the slides are changing in addition to providing a way to stop the changes.</li>
<li>If the carousel is rotating, the button's accessible name is <q>Stop Automatic Slide Show</q>, informing screen reader users that the slides are changing in addition to providing a way to stop the changes.</li>
<li>If the carousel is not rotating, the accessible name of the button is <q>Start Automatic Slide Show</q>.</li>
<li>If a user has activated the button to stop the show, the rotation will only restart if the button is activated. Moving keyboard focus or the mouse out of the carousel will not restart rotation.</li>
<li>If keyboard focus is inside the carousel, or if the mouse is hovering over the carousel, the button is disabled; it cannot be used to start rotation.</li>
Expand Down Expand Up @@ -551,7 +551,7 @@ <h3 id="rps_label_2">Tabs</h3>
<td>
<ul>
<li>Role <code>region</code> is implied for any <code>section</code> element that has an accessible name.</li>
<li>Defines the carousel and its controls as a land mark region.</li>
<li>Defines the carousel and its controls as a landmark region.</li>
</ul>
</td>
</tr>
Expand All @@ -566,7 +566,7 @@ <h3 id="rps_label_2">Tabs</h3>
<td>
<ul>
<li>Informs assistive technologies to identify the element as a "carousel" rather than as a "region".</li>
<li>Effects how assistive technologies render the role but does not effect functionality, such as commands for navigating to landmark regions.</li>
<li>Affects how assistive technologies render the role but does not affect functionality, such as commands for navigating to landmark regions.</li>
</ul>
</td>
</tr>
Expand Down Expand Up @@ -744,7 +744,7 @@ <h3 id="rps_label_2">Tabs</h3>
<td>
<ul>
<li>Informs assistive technologies to identify the element as a "slide" rather than as a "tabpanel".</li>
<li>Effects how assistive technologies render the role but does not effect assistive technology functionality.</li>
<li>Affects how assistive technologies render the role but does not affect assistive technology functionality.</li>
</ul>
</td>
</tr>
Expand Down
185 changes: 0 additions & 185 deletions examples/carousel/css/carousel-1-more-accessible.css

This file was deleted.

165 changes: 0 additions & 165 deletions examples/carousel/css/carousel-1.css

This file was deleted.

Loading