Combobox with list and both autocomplete: Fix issue with listbox not updating #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carmacleod
approved these changes
Feb 16, 2020
|
@spectranaut, @smhigley, seems like it would be a good idea to have tests for this behavior as specified in issue #1332 and associated with data-test-id="standard-single-line-editing-keys". What do you think? |
|
@smhigley, are you available for code and test review? If we are going to change/add tests, we could break that out into a separate issue and PR to keep this one simple. |
smhigley
approved these changes
Feb 18, 2020
|
@mcking65 I agree, I think a test should probably be added for backspace correctly updating the filter, but that can be a separate issue/PR |
|
Created #1345 to add regression testing for backspace. |
carmacleod
pushed a commit
to carmacleod/aria-practices
that referenced
this pull request
Feb 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1332.
Preview link for fix for listbox not properly updating using backspace (Issue 1332)
I added calls to the code that filters the options after the filter property is updated when backspace is pressed or if the length of the textbox value is less than the length of the filter property.
Review checklist