Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix spinbutton example query selector #1153

Merged
merged 2 commits into from
Aug 31, 2019
Merged

Fix spinbutton example query selector #1153

merged 2 commits into from
Aug 31, 2019

Conversation

backwardok
Copy link
Contributor

Fixes issue: #1151

The query selector for the spinbutton element was incomplete, which caused it to not query properly in Safari or IE.

This fix adds in the missing characters to the query so that it queries properly.

Before, clicking on the arrows didn't do anything and the element couldn't be tabbed to:
Video of clicking on arrows not changing the values in the datepicker

After, clicking on the arrows updates the value up/down and when tabbing to the picker values, using the up/down arrow keys adjusts the values:
Video of clicking on arrows updating values up or down, and then keyboard focus on values with the values changing in the datepicker

Fix spinbutton example query selector
e0add76 
The query selector for the `spinbutton` element was incomplete, which caused it to not query properly in Safari or IE.

This fix adds in the missing characters to the query so that it queries properly.
@backwardok
Copy link
Contributor Author

Also sorry about the infinite gifs - the tool I used doesn't have an option to not loop

@jnurthen jnurthen requested a review from jongund August 29, 2019 21:58
@jnurthen
Copy link
Member

Thanks Diane. @mcking65 I think this can be merged.

@backwardok backwardok mentioned this pull request Aug 31, 2019
Merged
@mcking65 mcking65 merged commit e451c93 into w3c:master Aug 31, 2019
michael-n-cooper pushed a commit that referenced this pull request Aug 31, 2019
Generated by TRAVIS-CI e451c93
3045a4b 
Date Picker Spin Button Example: fix  query selector (pull #1153)

Resolves issue #1151. The query selector for the `spinbutton` element was incomplete, which caused it to not query properly in Safari or IE.

This fix adds in the missing characters to the query so that it queries properly.
@backwardok backwardok deleted the backwardok-fix-spinbutton-selector branch September 1, 2019 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jongund jongund jongund approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@backwardok @jnurthen @jongund @mcking65