Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor menubar example: menuitem, group, and separator errors in roles, states, and props table in menubar/menubar-2/menubar-2.html #781

Closed
3 tasks done
spectranaut opened this issue Jul 17, 2018 · 2 comments
Closed
3 tasks done

Editor menubar example: menuitem, group, and separator errors in roles, states, and props table in menubar/menubar-2/menubar-2.html #781

spectranaut opened this issue Jul 17, 2018 · 2 comments
Assignees
@mcking65
Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo
Milestone
1.1 APG Release 2

Comments

@spectranaut
Copy link
Contributor

spectranaut commented Jul 17, 2018 •
edited by mcking65
Loading

In menubar/menubar-2/menubar-2.html:

  • In the "Role, Property, State, and Tabindex Attributes" table for "Menubar" -- role="menuitem" will be found on a a element not an li element
  • the aria-label attribute exists on the role="group" elements -- potentially this should be documented in the "Role, Property, State, and Tabindex Attributes" table for "Submenu"?
  • The role separator is used on a li element and should be documented.
@nschonni
Copy link
Contributor

I'm also seeing the rel stuff flagged too #779 (comment)

@mcking65 mcking65 changed the title Documentation bug in menubar/menubar-2/menubar-2.html Editor menubar example: menuitem, group, and separator errors in roles, states, and props table in menubar/menubar-2/menubar-2.html Jul 20, 2018
@mcking65 mcking65 added editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern labels Jul 20, 2018
@mcking65 mcking65 added this to the 1.1 APG Release 2 milestone Jul 20, 2018
@mcking65 mcking65 self-assigned this Jul 20, 2018
mcking65 added a commit that referenced this issue Jul 20, 2018
@mcking65
Editor menubar example: Fix errors in roles, states, and props docume…
71b437e 
…ntation for menuitem, group, and separator

For issue #781, modified roles, states, and properties documentation in menubar/menubar-2/menubar-2.html:
* For menubar, changed menuitem element to `a` from `li` for menuitem row and subsequent states and properties.
* For group role in submenu, added aria-label row.
* Added row for separator role in submenu.
* Other minor editorial revisions.
@mcking65
Copy link
Contributor

@spectranaut, you may want to merge master into bocoup to pick up commit 71b437e.

Note, there are two new data-test-id values in that commit, one for separator and one for label on group.

@mcking65 mcking65 mentioned this issue Jul 20, 2018
Closed
@mcking65 mcking65 added regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo and removed regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo labels Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcking65 mcking65

Labels
editorial Changes to prose that don't alter intended meaning, e.g., phrasing, grammar. May fix inaccuracies. Example Page Related to a page containing an example implementation of a pattern regression-testing Related to AVA regression tests of example pages or AVA framework implementation within repo
Projects
Menu, Menubar, and Menu Button patterns and examples development project
Status: Complete
Milestone
1.1 APG Release 2
Development

No branches or pull requests
3 participants
@spectranaut @nschonni @mcking65