Editor Menubar Example: Visual design does not distinguish between menuitemcheckbox and menuitemradio elements

[mcking65]

In his review of pull request #593 for changes to the editor menubar example, @sh0ji commented:

There is no visual indicator that the submenu items are a checkbox or radio. You just have to test it or guess to know whether clicking one will de-select another.

@carmacleod commented:

I looked at the old Windows Notepad menu, and it has the same behavior, i.e. the user cannot tell, other than perhaps by context, that a menu item is a checkbox. For example, View -> Status Bar, or Format -> Word Wrap. I'm not sure what the best solution to this problem is; does Mac have anything nice? One possibility is to use a red X (or an empty box) when the checkbox is not selected, and a green checkmark (or green checkmark in a box) when it is selected. It would be nice to distinguish between radio and checkbox as well, so, for example, an empty circle (unselected) or blue dot within circle (selected) for radio.

Let's decide on an approach and fix this problem.

[css-meeting-bot]

The ARIA Authoring Practices (APG) Task Force just discussed Issue 605: distinguishing menuitemcheckbox from menuitemradio.

The full IRC log of that discussion

<AnnAbbott> TOPIC: Issue 605: distinguishing menuitemcheckbox from menuitemradio
<MichielBijl> https://github.com//issues/605
<AnnAbbott> mck: requesting feedback
<mck> Link to proposal: https://rawgit.com/carmacleod/aria-practices/issue605/examples/menubar/menubar-2/menubar-2.html
<AnnAbbott> mck: should be able to distinguish between checkbox & radio in menu?
<AnnAbbott> mb: should be able to if grouped
<AnnAbbott> jn: no way to know a checkbox until checked
<AnnAbbott> jn: happy with example except off state doesn't display
<AnnAbbott> siri: off state should show up for kbd only users
<AnnAbbott> mb: does it display that way in native app?
<AnnAbbott> mck: when navigated, shouldn't only show on focus
<AnnAbbott> mck: only show on state?
<AnnAbbott> mck: take most accessible native approach unless compelling reason to do otherwise
<AnnAbbott> jg: could have different styling - just for selected state
<jamesn> GitHub: https://github.com//issues/605
<AnnAbbott> mb: agrees
<AnnAbbott> mck: comment in PR #853
<jemma> jemma: I agree with "too heavy lift example problem".
<AnnAbbott> jg: will comment in #853

[mcking65]

@carmacleod, thank you very much for pull request #853.

@jongund, @sh0ji, and @jnurthen, thank you for your feedback on the pr.

I have squashed and merged the changes with commit 08e5fe0; this issue is now resolved, and the editor menubar continues to get better!