Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(closing and will reopen) Support transactions in models #921

Closed
wants to merge 2 commits into from

Conversation

alflennik
Copy link
Contributor

@alflennik alflennik commented Feb 13, 2024

Apologies for the ginormous PR, believe it or not this is only half of the larger effort to implement transaction support.

The file change count is high but most of the changed files only have one line in their imports changed.

Here is a summary of the changes:

  1. Duplicates the server/models/services folder into server/models/services.deprecated
  2. Updates all imports of the model services to this new deprecated folder.

These changes allow the entire system to keep working without changes. This is the strategy I've used to break this larger effort into two PRs.

  1. Updates the server/models/services with a new object-based API, making it way easier than the old positional arguments to supply transactions.
  2. Updates the tests to support the new API. Where tests were missing, I added new tests.
  3. Makes all the models files consistent, CollectionJobService and TestPlanService were both diverging from the other model files and that made this kind of change difficult.

@alflennik alflennik changed the base branch from e2e-signin to main February 13, 2024 01:45
@alflennik alflennik changed the base branch from main to e2e-signin February 13, 2024 01:45
@alflennik
Copy link
Contributor Author

The diff might not be accurate, I'm seeing tons of unrelated changes.

@alflennik
Copy link
Contributor Author

Opened a new PR to fix the diff: #922

@alflennik alflennik closed this Feb 13, 2024
@alflennik alflennik changed the title Support transactions in models (closing and will reopen) Support transactions in models Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant