Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: declare css variables; move away from styled components #1338

Open
wants to merge 32 commits into
base: development
Choose a base branch
from
Open

feat: declare css variables; move away from styled components #1338

wants to merge 32 commits into from

Conversation

howard-e
Copy link
Contributor

@howard-e howard-e commented Mar 14, 2025 •
edited
Loading

This PR addresses multiple items raised through:

This PR also:

  • Switches from @emotion/* based styled components to introducing CSS modules (although much more optimizations can be done in that approach, open to additional feedback)
  • Defines and trims down css variables that were being used throughout the application (still more purging could be done)
  • Prioritizes responsive design in cases where it was lacking for smaller screens

NB. The file changes here are quite sizable (sorry!). But no functionality has been changed here outside of styling evaluations. Would recommended leaning on snapshot differences here initially.

howard-e added 29 commits March 6, 2025 14:28
@howard-e
Initial changes to styles to replace component level css files with c…
a43e558 
…ss modules; redone menu and home page; include clsx
@howard-e
Updated SummarizeTestPlanReports with a new module
4c608f6
@howard-e
Styling updates for /reports related pages
3cec970
@howard-e
Start updating styles for ManageTestQueue
8ece265
@howard-e
Various styling updates to Reports and Data Management related pages
99cca0c
@howard-e
Various styling updates to modals and dialogs
7168986
@howard-e
Move styles.module.css
6831af9
@howard-e
Update snapshots
9a414cc
@howard-e
More predictable module css name
e31daa4
@howard-e
Avoid unintentionally hiding content from DOM
f9864e2
@howard-e
TestQueue completed
63c6dbb
@howard-e
Test Run and Test Navigator changes
0039225
@howard-e
Finishing with TestRenderer related components
8a244c0
@howard-e
Visual tweaks
a5ef446
@howard-e
Handle CandidateReview Runs page
5f352e8
@howard-e
Additional Candidate Test Plan pages styling
52b1f16
@howard-e
Additional Candidate Test Plan pages styling
ffcc116
@howard-e
Update snapshots
ea1bb8c
@howard-e
Remove remaining emotion styled components
8540f14
@howard-e
Remove @emotion/styled
abd3942
@howard-e
Update snapshots
9007a74
@howard-e
Fix CandidateReview e2e tests
bc4919e
@howard-e
Fix TestQueue e2e tests
d2df090
@howard-e
Refactoring updates and update snapshots
541bcb8
@howard-e
Merge branch 'development' into standardize-styling
7ff4532 
# Conflicts:
#	client/tests/e2e/snapshots/saved/_account_settings.html
#	client/tests/e2e/snapshots/saved/_data-management.html
@howard-e
tweaks
ea056dc
@howard-e
Tweak form label sizes at specific widths in at and browser details m…
827c629 
…odal
@howard-e
Fix modal header element as type
3567347
@howard-e
Update snapshots
e7a5892
@howard-e howard-e changed the title Styling consolidation: declare css variables; move away from styled components feat: declare css variables; move away from styled components Mar 17, 2025
howard-e added 3 commits March 17, 2025 18:58
@howard-e
Merge branch 'development' into standardize-styling
accf9cd 
# Conflicts:
#	client/tests/e2e/snapshots/saved/_account_settings.html
#	client/tests/e2e/snapshots/saved/_data-management.html
@howard-e
Update snapshots
f12c217
@howard-e
Fix VersionString and modal-xxw widths
55cad3a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@howard-e