Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise length of generated GitHub issue link to avoid hitting URI max length #1334

Open
howard-e opened this issue Mar 6, 2025 · 0 comments
Labels
bug Something isn't working

Comments

@howard-e
Copy link
Contributor

howard-e commented Mar 6, 2025

We are hitting the GitHub URI length limits in special cases due to the amount of content included in the link. We should revise the generated content to check if we can appropriately trim the included content.

In shortening the URI length in this way, it only slightly mitigates the solution and other alternatives are also welcome.

The latest instance has happened when attempting to raise an issue for the conflict for Radio Group Example Using Roving tabindex V25.02.12, VoiceOver for macOS, Test 13. The following URI was being generated:

the generated URI length is 10089

https://github.com/bocoup/aria-at/issues/new?title=Feedback:%20%22Check%20the%20next%20radio%20button%20in%20a%20radio%20group%20by%20navigating%20to%20it%22%20(Radio%20Group%20Example%20Using%20Roving%20tabindex,%20Test%2012,%20V25.02.12)&labels=vo,feedback&body=%23%23%20Description%20of%20Behavior%0A%0A%3C!--%20Write%20your%20description%20here%20--%3E%0A%0A%23%23%20Test%20Setup%0A%0A-%20Test%20File%3A%20%5Btest-36-navToFirstRadio-voiceover_macos.collected.html%5D(https%3A%2F%2Faria-at.netlify.app%2Ftests%2Fradiogroup-roving-tabindex%2Ftest-36-navToFirstRadio-voiceover_macos.collected.html)%0A-%20AT%3A%20VoiceOver%20for%20macOS%20(Version%2015.1%20and%20above)%0A-%20Browser%3A%20Safari%0A%0A%3C!--%20The%20following%20data%20allows%20the%20issue%20to%20be%20imported%20into%20the%20ARIA%20AT%20App%20--%3E%0A%3C!--%20ARIA_AT_APP_ISSUE_DATA%20%3D%20%7B%22testPlanDirectory%22%3A%22radiogroup-roving-tabindex%22%2C%22versionString%22%3A%22V25.02.12%22%2C%22atName%22%3A%22VoiceOver%20for%20macOS%22%2C%22browserName%22%3A%22Safari%22%2C%22testRowNumber%22%3A36%2C%22testSequenceNumber%22%3A12%2C%22isCandidateReview%22%3Afalse%2C%22isCandidateReviewChangesRequested%22%3Afalse%7D%20--%3E%0A%0A%23%23%20Review%20Conflicts%20for%20%22Check%20the%20next%20radio%20button%20in%20a%20radio%20group%20by%20navigating%20to%20it%22%0A%0A%0A1.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Down%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0ANavigate%20backwards%20from%20here%20link%0AYou%20are%20currently%20on%20a%20link.%20To%20click%20this%20link%2C%20press%20Control-Option-Space.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20Voiceover%20cursor%20moved%20out%20of%20the%20radio%20group.%2C%20Impact%3A%20SEVERE).%0A%0A2.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Down%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0ANavigate%20backwards%20from%20here%20link%0AYou%20are%20currently%20on%20a%20link.%20To%20click%20this%20link%2C%20press%20Control-Option-Space.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20Voiceover%20cursor%20moved%20out%20of%20the%20radio%20group.%2C%20Impact%3A%20SEVERE).%0A%0A3.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Down%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0ANavigate%20backwards%20from%20here%20link%0AYou%20are%20currently%20on%20a%20link.%20To%20click%20this%20link%2C%20press%20Control-Option-Space.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20Voiceover%20cursor%20moved%20out%20of%20the%20radio%20group.%2C%20Impact%3A%20SEVERE).%0A%0A4.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Down%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0ANavigate%20backwards%20from%20here%20link%0AYou%20are%20currently%20on%20a%20link.%20To%20click%20this%20link%2C%20press%20Control-Option-Space.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20Voiceover%20cursor%20moved%20out%20of%20the%20radio%20group.%2C%20Impact%3A%20SEVERE).%0A%0A5.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Down%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0ANavigate%20backwards%20from%20here%20link%0AYou%20are%20currently%20on%20a%20link.%20To%20click%20this%20link%2C%20press%20Control-Option-Space.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20Voiceover%20cursor%20moved%20out%20of%20the%20radio%20group.%2C%20Impact%3A%20SEVERE).%0A%0A6.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Down%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0ANavigate%20backwards%20from%20here%20link%0AYou%20are%20currently%20on%20a%20link.%20To%20click%20this%20link%2C%20press%20Control-Option-Space.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20Voiceover%20cursor%20moved%20out%20of%20the%20radio%20group.%2C%20Impact%3A%20SEVERE).%0A%0A7.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Right%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0Aend%20of%20Pizza%20Crust%20radio%20group%0AYou%20are%20currently%20on%20a%20radio%20group.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20VoiceOver%20cursor%20moved%20to%20the%20end%20of%20the%20group.%2C%20Impact%3A%20SEVERE).%0A%0A8.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Right%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0Aend%20of%20Pizza%20Crust%20radio%20group%0AYou%20are%20currently%20on%20a%20radio%20group.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20VoiceOver%20cursor%20moved%20to%20the%20end%20of%20the%20group.%2C%20Impact%3A%20SEVERE).%0A%0A9.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Right%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0Aend%20of%20Pizza%20Crust%20radio%20group%0AYou%20are%20currently%20on%20a%20radio%20group.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20VoiceOver%20cursor%20moved%20to%20the%20end%20of%20the%20group.%2C%20Impact%3A%20SEVERE).%0A%0A10.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Right%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0Aend%20of%20Pizza%20Crust%20radio%20group%0AYou%20are%20currently%20on%20a%20radio%20group.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20VoiceOver%20cursor%20moved%20to%20the%20end%20of%20the%20group.%2C%20Impact%3A%20SEVERE).%0A%0A11.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Right%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0Aend%20of%20Pizza%20Crust%20radio%20group%0AYou%20are%20currently%20on%20a%20radio%20group.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20VoiceOver%20cursor%20moved%20to%20the%20end%20of%20the%20group.%2C%20Impact%3A%20SEVERE).%0A%0A12.%20%23%23%23%20Unexpected%20Behaviors%20for%20%22Right%20Arrow%20(arrow%20quick%20key%20nav%20off)%22%20Command%0A%0A*%20Tester%20jha11y%20recorded%20output%20%22Regular%20crust%2C%20selected%2C%20radio%20button%2C%201%20of%203%0AYou%20are%20currently%20on%20a%20selected%20radio%20button%2C%201%20of%203.%20%22%20and%20noted%20no%20unexpected%20behavior.%0A*%20Tester%20IsaDC%20recorded%20output%20%22%0Aend%20of%20Pizza%20Crust%20radio%20group%0AYou%20are%20currently%20on%20a%20radio%20group.%22%20and%20noted%20%22Reading%20cursor%20position%20changed%20in%20an%20unexpected%20manner%22%20(Details%3A%20VoiceOver%20cursor%20moved%20to%20the%20end%20of%20the%20group.%2C%20Impact%3A%20SEVERE).%0A

@howard-e howard-e added the bug Something isn't working label Mar 6, 2025
@howard-e howard-e changed the title Revise length of generated GitHub issue link Revise length of generated GitHub issue link to avoid hitting URI max length Mar 6, 2025
howard-e added a commit that referenced this issue Mar 17, 2025
Create March 17, 2025 Release [2]

Includes the following changes:

* #1336, which addresses #1334
* #1340 
* #1339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant