Changing useCache boolean to updateViaCache enum #1107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TODO:
|
|
HTML changes whatwg/html#2515 - I need to do some work here. |
jungkees
reviewed
May 15, 2017
docs/index.bs
Outdated
| @@ -201,7 +201,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe | |||
|
|
|||
| A [=/service worker registration=] has an associated <dfn export id="dfn-last-update-check-time">last update check time</dfn>. It is initially set to null. | |||
|
|
|||
| A [=/service worker registration=] has an associated <dfn export id="dfn-use-cache">use cache</dfn> (a boolean). It is initially set to false. | |||
| A [=/service worker registration=] has an associated <dfn export id="dfn-update-via-cache">update via cache mode</dfn>, which is "`imports`", "`all`", or "`never`". It is initially set to "`imports`". | |||
There was a problem hiding this comment.
The IDL definition for the enum uses "none" instead of "never". I think "none" sounds better considering service-workers mode uses "none".
There was a problem hiding this comment.
Oh wow, good catch
jungkees
reviewed
May 15, 2017
docs/index.bs
Outdated
| @@ -2276,7 +2282,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe | |||
| 1. Let |registration| be |serviceWorker|'s [=containing service worker registration=]. | |||
| 1. Set |request|'s [=service-workers mode=] to "`foreign`". | |||
| 1. Set |request|'s [=request/cache mode=] to "<code>no-cache</code>" if any of the following are true: | |||
| * |registration|'s [=service worker registration/use cache=] is false. | |||
| * |registration|'s [=service worker registration/update via cache mode=] is "`never`". | |||
There was a problem hiding this comment.
"none" or "never" depending on the choice.
jungkees
reviewed
May 15, 2017
docs/index.bs
Outdated
| @@ -2392,7 +2398,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe | |||
|
|
|||
| A <a>job</a> has a <dfn id="dfn-job-worker-type">worker type</dfn> ("<code>classic</code>" or "<code>module</code>"). | |||
|
|
|||
| A <a>job</a> has a <dfn id="dfn-job-use-cache">use cache</dfn> (a boolean). | |||
| A <a>job</a> has an <dfn id="dfn-job-update-via-cache-mode">update via cache mode</dfn>, which is "`imports`", "`all`", or "`never`". | |||
There was a problem hiding this comment.
"none" or "never" depending on the choice.
jungkees
reviewed
May 15, 2017
docs/v1/index.bs
Outdated
| @@ -190,7 +190,7 @@ spec: webappsec-referrer-policy; urlPrefix: https://w3c.github.io/webappsec-refe | |||
|
|
|||
| A [=/service worker registration=] has an associated <dfn export id="dfn-last-update-check-time">last update check time</dfn>. It is initially set to null. | |||
|
|
|||
| A [=/service worker registration=] has an associated <dfn export id="dfn-use-cache">use cache</dfn> (a boolean). It is initially set to false. | |||
| A [=/service worker registration=] has an associated <dfn export id="dfn-update-via-cache">update via cache mode</dfn>, which is "`imports`", "`all`", or "`never`". It is initially set to "`imports`". | |||
There was a problem hiding this comment.
Same as nightly: Use "none" or "never" consistently.
|
@jakearchibald, sorry for the late feedback. I suppose you're extremely busy for now. Please check this out when you find time. |
b0971f0 to
dcf65a6
Compare
|
@jungkees updated this, and also updated the tests web-platform-tests/wpt#5515 |
|
LGTM. I'll merge this as HTML's already merged the related changes and the tests are underway. |
|
Cheers @jungkees! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.