Mention SameSite cookies in accounts fetch #550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR aligns the spec with the Chrome implementation. But there is some feedback that we may need to change the implementation on #587. We can either keep this PR pending the resolution of that or land it and possibly address the changes from that later. |
cbiesinger
reviewed
Sep 12, 2024
This PR adds a mention to which cookies ought to be sent in the accounts fetch. Once cookie layering work is done, we can remove this note and properly specify it.
69fdf09 to
5d4f161
Compare
Updated, ptal |
cbiesinger
approved these changes
Sep 19, 2024
TallTed
reviewed
Sep 20, 2024
TallTed
reviewed
Sep 20, 2024
Co-authored-by: Ted Thibodeau Jr <tthibodeau@openlinksw.com>
bvandersloot-mozilla
approved these changes
Feb 14, 2025
github-actions bot
added a commit
that referenced
this pull request
Feb 14, 2025
SHA: a895902 Reason: push, by npm1 Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot
added a commit
to mattdanielbrown/WebID
that referenced
this pull request
Feb 14, 2025
SHA: a895902 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a mention to which cookies ought to be sent in the accounts fetch. Once cookie layering work is done, we can remove this note and properly specify it.
Relevant issue: #609
Preview | Diff