Have the workpad service show 404 notification if the saved object to…

… load is not found (elastic#709)

* workpad service: show 404 error from workpad saved object not found

* make the notification say "Canvas"

* Notifier not a constructor?

public/apps/workpad/routes.js

@@ -1,4 +1,5 @@
 import * as workpadService from '../../lib/workpad_service';
+import { notify } from '../../lib/notify';
 import { getDefaultWorkpad } from '../../state/defaults';
 import { setWorkpad } from '../../state/actions/workpad';
 import { setAssets, resetAssets } from '../../state/actions/assets';
@@ -32,10 +33,13 @@ export const routes = [
           // load workpad if given a new id via url param
           const currentWorkpad = getWorkpad(getState());
           if (params.id !== currentWorkpad.id) {
-            // TODO: handle missing/invalid workpad id's (mostly 404)
-            const { assets, ...workpad } = await workpadService.get(params.id);
-            dispatch(setWorkpad(workpad));
-            dispatch(setAssets(assets));
+            try {
+              const { assets, ...workpad } = await workpadService.get(params.id);
+              dispatch(setWorkpad(workpad));
+              dispatch(setAssets(assets));
+            } catch (fetchErr) {
+              notify.error(fetchErr);
+            }
           }
 
           // fetch the workpad again, to get changes

public/components/workpad_loader/index.js

@@ -19,7 +19,7 @@ export const WorkpadLoader = compose(
   withHandlers({
     // Workpad creation via navigation
     createWorkpad: props => async workpad => {
-      // workpad passed in, create and load it
+      // workpad data uploaded, create and load it
       if (workpad != null) {
         await workpadService.create(workpad);
         props.router.navigateTo('loadWorkpad', { id: workpad.id, page: 1 });

public/lib/notify.js

@@ -1,8 +1,12 @@
 import { notify as kbnNotify } from 'ui/notify';
 
 export const notify = {
-  error(msg, opts = {}) {
-    kbnNotify.error(msg, opts);
+  /*
+   * @param {Object} err: Error object
+   * @param {Object} opts: option to override notification icon
+   */
+  error(err, opts = {}) {
+    kbnNotify.error(err, opts);
   },
   warning(msg, opts = {}) {
     kbnNotify.warning(msg, opts);

public/lib/workpad_service.js

@@ -10,7 +10,10 @@ export function create(workpad) {
 }
 
 export function get(workpadId) {
-  return fetch.get(`${apiPath}/${workpadId}`).then(res => res.data);
+  return fetch
+    .get(`${apiPath}/${workpadId}`)
+    .then(res => res.data)
+    .catch(({ response }) => Promise.reject(response));
 }
 
 export function update(id, workpad) {

server/routes/workpad.js

@@ -98,7 +98,8 @@ export function workpad(server) {
       return savedObjectsClient
         .get(CANVAS_TYPE, id)
         .then(obj => obj.attributes)
-        .then(formatResponse(reply));
+        .then(formatResponse(reply))
+        .catch(formatResponse(reply));
     },
   });