Skip to content

Commit

Permalink
#14 Fix CI
Browse files Browse the repository at this point in the history
Postgres: attempt using the official image. I haven't done this enough to know honestly and I may need a docker login regardless.
Dialyzer:
No longer supports `race_conditions`: jeremyjh/dialyxir#470.
Unknown is included by default I believe so there's no need to include it again.
Add MP3Stat exclusions tied to the line numbers. If I drastically change this file I need to follow the warnings too. I'm fine with making this whitelist as I don't think Beatseek had these checks applied or they may have taken different approaches.
  • Loading branch information
w0rd-driven committed Jan 27, 2023
1 parent 2bde825 commit be94e4e
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 4 deletions.
5 changes: 4 additions & 1 deletion .dialyzer_ignore.exs
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,7 @@
#
# More info in the Dialyxir README:
# https://github.com/jeremyjh/dialyxir#elixir-term-format
[]
[
{"lib/beatseek/mp3stat.ex", :call, 166},
{"lib/beatseek/mp3stat.ex", :guard_fail, 289},
]
2 changes: 1 addition & 1 deletion .github/workflows/elixir-build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:
# Remove if you don't need a database
services:
db:
image: postgres/postgres:14
image: postgres:14
env:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: postgres
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/nightly-integration-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
# Remove if you don't need a database
services:
db:
image: postgres/postgres:14
image: postgres:14
env:
POSTGRES_USER: postgres
POSTGRES_PASSWORD: postgres
Expand Down
2 changes: 1 addition & 1 deletion mix.exs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ defmodule Beatseek.MixProject do
dialyzer: [
ignore_warnings: ".dialyzer_ignore.exs",
plt_file: {:no_warn, "priv/plts/dialyzer.plt"},
flags: [:error_handling, :race_conditions, :unknown],
flags: [:error_handling],
# Error out when an ignore rule is no longer useful so we can remove it
list_unused_filters: true
]
Expand Down

0 comments on commit be94e4e

Please sign in to comment.