Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Consumer compatibility with laravel v9.42.0 (#499) #500

Closed
wants to merge 2 commits into from
Closed

Fix Consumer compatibility with laravel v9.42.0 (#499) #500

wants to merge 2 commits into from

Conversation

Arthur-Sk
Copy link

Closes #499

@dammy001
Copy link

Hey, @vladkucherov could you please merge this ASAP?

@sturtond
Copy link

Broke for me too

sturtond
sturtond approved these changes Nov 30, 2022
View reviewed changes
Copy link

@sturtond sturtond left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on Laravel 9.42

GarryLai
GarryLai approved these changes Dec 1, 2022
View reviewed changes
Copy link

@GarryLai GarryLai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working on 9.42

@jeromegamez
Copy link
Contributor

@vyuldashev Since I've subscribed to this PR and receive all the approval reviews as well… you can disable random people from approving PRs in the project settings (Settings -> Moderation Options -> Code Review Limits):

hAz5
hAz5 approved these changes Dec 4, 2022
View reviewed changes
Copy link

@hAz5 hAz5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works on v9.42

hAz5
hAz5 approved these changes Dec 4, 2022
View reviewed changes
Copy link

@hAz5 hAz5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested and works on v9.42

sharjeelz
sharjeelz reviewed Dec 4, 2022
View reviewed changes
Copy link

@sharjeelz sharjeelz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect

Fanamurov
Fanamurov approved these changes Dec 5, 2022
View reviewed changes
Copy link

@Fanamurov Fanamurov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as well

sjaakkie
sjaakkie reviewed Dec 5, 2022
View reviewed changes
src/Consumer.php Outdated Show resolved Hide resolved
@medeirosinacio
Copy link

Hey, @vladkucherov could you please merge this ASAP?

@Lendy10
Copy link

Lendy10 commented Dec 8, 2022

would you please merge this ASAP mr. @vladkucherov?

@medeirosinacio
Copy link

I think @vladkucherov is not developing anymore, his github and twitter seem to be abandoned. This repositories itself has several open pull requests without response.

This is the best native implementation package with Laravel.

Could it be that we shouldn't work on a fork of this project and have more collaborators to help maintain it?

@sturtond
Copy link

sturtond commented Dec 8, 2022

I think @vladkucherov is not developing anymore, his github and twitter seem to be abandoned. This repositories itself has several open pull requests without response.

This is the best native implementation package with Laravel.

Could it be that we shouldn't work on a fork of this project and have more collaborators to help maintain it?

I see he has no activity since July,

I hope this isnt the case

@sharjeelz
Copy link

when we will have this merge?

@iamfarhad
Copy link

you can use of my laravel rabbitmq package

https://github.com/iamfarhad/LaravelRabbitMQ

@amiranbarigreenweb
Copy link

I need this too

AliBayat
AliBayat approved these changes Jan 1, 2023
View reviewed changes
Copy link

@AliBayat AliBayat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it works fine on 9.42 and above (tested also on 9.45)

@vladkucherov
Copy link
Contributor

Hey guys, I'm not the author of this package, nor a maintainer who can merge this PR.
I suppose you should reach @vyuldashev

@koAndy
Copy link

koAndy commented Jan 13, 2023

@vyuldashev please merge this!

@iamfarhad
Copy link

@vyuldashev please merge this!

you can use my laravel rabbitmq package

https://github.com/iamfarhad/LaravelRabbitMQ

@M-Porter
Copy link
Collaborator

Resolved by #502

@M-Porter M-Porter closed this Jan 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fanamurov Fanamurov Fanamurov approved these changes

@iamfarhad iamfarhad iamfarhad approved these changes

@sjaakkie sjaakkie sjaakkie approved these changes

@vladkucherov vladkucherov vladkucherov approved these changes

@sharjeelz sharjeelz sharjeelz approved these changes

@FelipeeDev FelipeeDev FelipeeDev approved these changes

@skater4 skater4 skater4 approved these changes

@AliBayat AliBayat AliBayat approved these changes

@SofLesc SofLesc SofLesc approved these changes

@hAz5 hAz5 hAz5 approved these changes

@GarryLai GarryLai GarryLai approved these changes

@dammy001 dammy001 dammy001 approved these changes

@sturtond sturtond sturtond approved these changes

@medeirosinacio medeirosinacio medeirosinacio approved these changes

@amiranbari amiranbari amiranbari approved these changes

@joao-lemes joao-lemes joao-lemes approved these changes

@vlazaay vlazaay vlazaay approved these changes

@SublateSamuel SublateSamuel SublateSamuel approved these changes

@amiranbarigreenweb amiranbarigreenweb amiranbarigreenweb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone