-
-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor[venom]: make venom repr parseable #4402
refactor[venom]: make venom repr parseable #4402
Conversation
make the repr implementations for venom data structures (IRContext, IRFunction, IRBasicBlock) emit strings which will round-trip through the parser. remove a dead function (`str_short()`)
- ensure instructions are terminated with newline (otherwise they can continue parsing next line) - allow signed ints for IRLiteral
%import common.CNAME | ||
%import common.DIGIT | ||
%import common.LETTER | ||
%import common.WS | ||
%import common.INT | ||
%import common.SIGNED_INT | ||
%import common.ESCAPED_STRING |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering if it would be better to just change up some of the labels instead of parsing escaped string (I dont know how many cases are there I stumbled so far on case with the space which could be replaced by underscore)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i could do it both ways honestly, but this seemed nicer for debugging (you can imagine the frontend generating a sentence or description of where it came from for a label)
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture