Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor[venom]: move commutative instruction set #4307

Merged
merged 2 commits into from
Oct 15, 2024

Conversation

HodanPlodky
Copy link
Collaborator

@HodanPlodky HodanPlodky commented Oct 15, 2024

What I did

Moved the commutative instruction set from venom_to_assembly.py into the basicblock.py and added the convenience method in IRInstruction

How to verify it

test

Commit message

this commit moves the commutative instruction set from
`venom_to_assembly.py` into `basicblock.py` and adds a convenience
method in `IRInstruction`.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.74%. Comparing base (990a6fa) to head (3a0c0b0).
Report is 61 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4307      +/-   ##
==========================================
- Coverage   91.40%   88.74%   -2.67%     
==========================================
  Files         112      112              
  Lines       15920    15923       +3     
  Branches     2693     2693              
==========================================
- Hits        14552    14131     -421     
- Misses        934     1274     +340     
- Partials      434      518      +84     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper changed the title chore[venom]: moved commutative instruction set refactor[venom]: move commutative instruction set Oct 15, 2024
@charles-cooper charles-cooper merged commit 8f9a8ca into vyperlang:master Oct 15, 2024
158 of 159 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants