-
-
Notifications
You must be signed in to change notification settings - Fork 841
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat[venom]: add load elimination pass #4265
feat[venom]: add load elimination pass #4265
Conversation
3c4f250
to
6923199
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4265 +/- ##
==========================================
- Coverage 91.74% 89.99% -1.76%
==========================================
Files 118 119 +1
Lines 16581 16615 +34
Branches 2789 2796 +7
==========================================
- Hits 15213 14953 -260
- Misses 936 1172 +236
- Partials 432 490 +58 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Fix lint Co-authored-by: Harry Kalogirou <harkal@nlogn.eu>
|
||
if inst.opcode == "mstore": | ||
# mstore [val, ptr] | ||
memory = (inst.operands[1], inst.operands[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we just switch it so the order in which the value and ptr is store we cannot always switch them (just to make it simple to reason about it)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the reason i wrote it like that is to kind of hint at a future implementation with lattice (mapping locations to values), it will look like
val, ptr = inst.operands
memory[ptr] = val
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i rewrote it a bit so that we don't have to look at the reversal of the indexes
6faffba
--------- Co-authored-by: HodanPlodky <36966616+HodanPlodky@users.noreply.github.com>
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture