-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[lang]: fix .vyi
function body check
#4177
fix[lang]: fix .vyi
function body check
#4177
Conversation
vyper/semantics/types/function.py
Outdated
body = funcdef.body | ||
|
||
if len(body) != 1 or not ( | ||
isinstance(body[0], vy_ast.Expr) and isinstance(body[0].get("value"), vy_ast.Ellipsis) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
once we have refined the type of body[0]
, we don't need to use get()
, we can just directly reference .value
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
addressed in: f006571
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4177 +/- ##
===========================================
- Coverage 91.35% 46.19% -45.16%
===========================================
Files 109 109
Lines 15613 15614 +1
Branches 3436 3436
===========================================
- Hits 14263 7213 -7050
- Misses 920 7847 +6927
- Partials 430 554 +124 ☔ View full report in Codecov by Sentry. |
.vyi
function body check
What I did
How to verify it
commit message