Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[docs]: add more detail to modules docs #4087

Merged
merged 5 commits into from
Jun 1, 2024

Conversation

charles-cooper
Copy link
Member

@charles-cooper charles-cooper commented Jun 1, 2024

What I did

How I did it

How to verify it

Commit message

- update technical notes in using modules (reference the VIP)
- note about linearization check
- exports of interfaces

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

Copy link
Member

@fubuloubu fubuloubu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One point of confusion, looks fine otherwise

docs/using-modules.rst Outdated Show resolved Hide resolved
docs/using-modules.rst Outdated Show resolved Hide resolved
docs/using-modules.rst Outdated Show resolved Hide resolved
Copy link

codecov bot commented Jun 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.33%. Comparing base (bb9129a) to head (7be05e9).

Current head 7be05e9 differs from pull request most recent head 18f6a81

Please upload reports for the commit 18f6a81 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4087      +/-   ##
==========================================
- Coverage   91.24%   90.33%   -0.91%     
==========================================
  Files         109      109              
  Lines       15548    15548              
  Branches     3416     3416              
==========================================
- Hits        14186    14046     -140     
- Misses        928     1040     +112     
- Partials      434      462      +28     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper charles-cooper merged commit 80dcee2 into vyperlang:master Jun 1, 2024
156 checks passed
@charles-cooper charles-cooper deleted the docs/v0.4.0-misc branch June 1, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants