feat[lang]!: make internal decorator optional

tests/functional/codegen/features/decorators/test_public.py

@@ -10,12 +10,3 @@ def foo():
 """
 
     assert_compile_failed(lambda: get_contract(code), FunctionDeclarationException)
-
-
-def test_invalid_if_visibility_isnt_declared(assert_compile_failed, get_contract):
-    code = """
-def foo():
-    x: uint256 = 1
-"""
-
-    assert_compile_failed(lambda: get_contract(code), FunctionDeclarationException)

tests/functional/codegen/features/test_internal_call.py

@@ -11,7 +11,6 @@
 
 def test_selfcall_code(get_contract):
     selfcall_code = """
-@internal
 def _foo() -> int128:
     return 3
 
@@ -28,15 +27,13 @@ def bar() -> int128:
 
 def test_selfcall_code_2(get_contract, keccak):
     selfcall_code_2 = """
-@internal
 def _double(x: int128) -> int128:
     return x * 2
 
 @external
 def returnten() -> int128:
     return self._double(5)
 
-@internal
 def _hashy(x: bytes32) -> bytes32:
     return keccak256(x)
 

tests/functional/syntax/exceptions/test_function_declaration_exception.py

@@ -19,16 +19,6 @@ def foo() -> int128:
     pass
     """,
     """
-def foo() -> int128:
-    q: int128 = 111
-    return q
-    """,
-    """
-q: int128
-def foo() -> int128:
-    return self.q
-    """,
-    """
 @external
 def test_func() -> int128:
     return (1, 2)

vyper/semantics/types/function.py

@@ -349,8 +349,6 @@ def from_vyi(cls, funcdef: vy_ast.FunctionDef) -> "ContractFunctionT":
                 "function body in an interface can only be `...`!", funcdef
             )
 
-        assert function_visibility is not None  # mypy hint
-
         return cls(
             funcdef.name,
             positional_args,
@@ -405,8 +403,7 @@ def from_FunctionDef(cls, funcdef: vy_ast.FunctionDef) -> "ContractFunctionT":
                 )
             if function_visibility != FunctionVisibility.DEPLOY:
                 raise FunctionDeclarationException(
-                    f"Constructor must be marked as `@deploy`, not `@{function_visibility}`",
-                    funcdef,
+                    "Constructor must be marked as `@deploy`", funcdef
                 )
             if return_type is not None:
                 raise FunctionDeclarationException(
@@ -419,9 +416,6 @@ def from_FunctionDef(cls, funcdef: vy_ast.FunctionDef) -> "ContractFunctionT":
                     "Constructor may not use default arguments", funcdef.args.defaults[0]
                 )
 
-        # sanity check
-        assert function_visibility is not None
-
         return cls(
             funcdef.name,
             positional_args,
@@ -702,7 +696,7 @@ def _parse_return_type(funcdef: vy_ast.FunctionDef) -> Optional[VyperType]:
 
 def _parse_decorators(
     funcdef: vy_ast.FunctionDef,
-) -> tuple[Optional[FunctionVisibility], StateMutability, bool]:
+) -> tuple[FunctionVisibility, StateMutability, bool]:
     function_visibility = None
     state_mutability = None
     nonreentrant_node = None
@@ -758,9 +752,7 @@ def _parse_decorators(
             raise StructureException("Bad decorator syntax", decorator)
 
     if function_visibility is None:
-        raise FunctionDeclarationException(
-            f"Visibility must be set to one of: {', '.join(FunctionVisibility.values())}", funcdef
-        )
+        function_visibility = FunctionVisibility.INTERNAL
 
     if state_mutability is None:
         # default to nonpayable
@@ -769,8 +761,6 @@ def _parse_decorators(
     if state_mutability == StateMutability.PURE and nonreentrant_node is not None:
         raise StructureException("Cannot use reentrancy guard on pure functions", nonreentrant_node)
 
-    # assert function_visibility is not None  # mypy
-    # assert state_mutability is not None  # mypy
     nonreentrant = nonreentrant_node is not None
     return function_visibility, state_mutability, nonreentrant