refactor[test]: change default expected exception type

[DanielSchiavini]

What I did

Changed expected tx_failed exception to be ExecutionReverted
Fixed tests that raised the more generic EvmError

Cute Animal Picture

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.95%. Comparing base (ace3789) to head (41061c3).

❗ Current head 41061c3 differs from pull request most recent head f5841c5. Consider uploading reports for the commit f5841c5 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #4004      +/-   ##
==========================================
- Coverage   90.89%   87.95%   -2.94%     
==========================================
  Files         103      103              
  Lines       14914    14914              
  Branches     3306     3306              
==========================================
- Hits        13556    13118     -438     
- Misses        937     1299     +362     
- Partials      421      497      +76     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[charles-cooper]

out of scope but these should really all be ExecutionReverted actually; it should be fixed by #3925

[charles-cooper]

not a huge fan of the dynamic lookup in https://github.com/vyperlang/vyper/pull/4004/files#diff-cb5228f23a8a9317e7de9bc3780d62cdfd69bb2655261be60e55143a874615f4R445 but besides that it looks good