-
-
Notifications
You must be signed in to change notification settings - Fork 836
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix[venom]: fix branch eliminator cases in sccp #4003
fix[venom]: fix branch eliminator cases in sccp #4003
Conversation
in sccp, when the operand of `jnz` or `assert` is already an IRLiteral (this is most easily seen by disabling the IRnode branch eliminator), the compiler will panic.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
djmp
is also "vulnerable" to passing a literal.
I think a better solution would be to never arrive here with literals in conditions. This will allow the algorithm to remain pure. A better place might be the remove_unreachable_blocks
pass.
how about literals inside of assertions? |
refactor: rename _get_lattice to _from_lattice, change it to a method
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #4003 +/- ##
==========================================
- Coverage 90.78% 89.91% -0.87%
==========================================
Files 105 103 -2
Lines 15248 14915 -333
Branches 3362 3303 -59
==========================================
- Hits 13843 13411 -432
- Misses 966 1053 +87
- Partials 439 451 +12 ☔ View full report in Codecov by Sentry. |
* changed the index type of lattice to `IRVariable` (it should only have variables) * add getter/setter methods that also check types to cache future regretions * add `_eval_lattice_with_op()` to evaluate the lattice with an operant * revert `_eval()` changes * unify the handling of `store`
i'm going to revert the changes to |
What I did
How I did it
How to verify it
Commit message
Description for the changelog
Cute Animal Picture