Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat[lang]: blobhash #3979

Closed
wants to merge 9 commits into from
Closed

feat[lang]: blobhash #3979

wants to merge 9 commits into from

Conversation

tserg
Copy link
Collaborator

@tserg tserg commented Apr 27, 2024

What I did

Support blobhash(uint256).

How I did it

How to verify it

Commit message

This commit adds access to the `BLOBHASH` opcode via a new `blobhash()` 
builtin. The opcode was introduced in EIP-4844.

Description for the changelog

Cute Animal Picture

Put a link to a cute animal picture inside the parenthesis-->

@@ -1212,13 +1212,23 @@ class BlockHash(BuiltinFunctionT):
_return_type = BYTES32_T

@process_inputs
def build_IR(self, expr, args, kwargs, contact):
def build_IR(self, expr, args, kwargs, context):
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed a typo here

@codecov-commenter
Copy link

codecov-commenter commented Apr 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (7d28a50) to head (d6ba9a2).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3979   +/-   ##
=======================================
  Coverage   90.81%   90.81%           
=======================================
  Files          98       98           
  Lines       14867    14877   +10     
  Branches     3309     3311    +2     
=======================================
+ Hits        13501    13511   +10     
  Misses        945      945           
  Partials      421      421           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@charles-cooper
Copy link
Member

dup of #3962 -- relevant changes from this PR have already been incorporated there (26d6fdb)

@tserg tserg deleted the feat/blobhash branch May 3, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants