feat: Support blob basefee opcode #3878
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #3878 +/- ##
==========================================
+ Coverage 86.10% 86.12% +0.01%
==========================================
Files 92 92
Lines 14017 14022 +5
Branches 3079 3081 +2
==========================================
+ Hits 12070 12076 +6
+ Misses 1515 1513 -2
- Partials 432 433 +1 ☔ View full report in Codecov by Sentry. |
| @@ -265,6 +265,14 @@ def parse_Attribute(self): | |||
| return IRnode.from_list(["callvalue"], typ=UINT256_T) | |||
| elif key == "msg.gas": | |||
| return IRnode.from_list(["gas"], typ=UINT256_T) | |||
| elif key == "block.blobbasefee": | |||
| if not version_check(begin="cancun"): | |||
There was a problem hiding this comment.
this should throw an exception, not warn
There was a problem hiding this comment.
What is the proper way to do that? It seems like everything else just warns on wrong version?
|
superseded by #3945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP, draft pr