feat[logs]: read logs from ABI #238
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hmm this is interesting, but how does it fit into boa workflow? typical boa workflow is to initialize an evm environment (local, fork or network) and then run tests against that. what is the workflow for this feature? maybe |
|
my other comment here is there is probably some amount of code overlap with the existing log parsing code, so we should try not to duplicate code if it makes sense to merge the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Backported the ABI Log changes from the Vyper tests back to titanoboa.
How I did it
Implemented log parsing in the ABI contracts.
How to verify it
Description for the changelog
Cute Animal Picture