Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6684: new Debian package repo snapshot logic #2

Closed
wants to merge 1 commit into from

Conversation

HollyGurza
Copy link

save information about all installed packages and teir source repo, including a temporary packages

list of packages will stored in the file chroot.packages.all.info

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Other (please describe):

Related Task(s)

Related PR(s)

Proposed changes

How to test

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

save information about all installed packages and teir source repo, including temporary packages
@c-po
Copy link
Member

c-po commented Sep 11, 2024

We do not use this package during our build process.

Any reason to not place it in build hooks? https://github.com/vyos/vyos-build/tree/current/data/live-build-config/hooks/live

@HollyGurza
Copy link
Author

We do not use this package during our build process.

Any reason to not place it in build hooks? https://github.com/vyos/vyos-build/tree/current/data/live-build-config/hooks/live

we cannot use build hooks because we should to save information about temporary packages but when hooks are working this information is already cleaned

@dmbaturin
Copy link
Member

We do not use this package during our build process.

There was a plan to use it for Kim's fixed to the raw image build process, which we ended up not using because the new flavor system uses a different process. But for making snapshots during the release process we'll need to install it on the build host. We should probably make a PR to use this package in the build container image.

@HollyGurza
Copy link
Author

i think this PR can be closed, the actual patch is stored in the vyos-build repo
(vyos/vyos-build#758)

@HollyGurza HollyGurza closed this Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants