Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove inexisting config option from example #1419

Merged
merged 1 commit into from
May 5, 2024
Merged

Remove inexisting config option from example #1419

merged 1 commit into from
May 5, 2024

Conversation

nvollmar
Copy link
Contributor

@nvollmar nvollmar commented May 5, 2024

Change Summary

This came in with the pppoe server documentation rework.
But the pppoe-server section currently does not have a config outside-address.

Checklist:

@github-actions github-actions bot requested a review from rebortg May 5, 2024 19:43
@rebortg rebortg merged commit da79ee0 into vyos:current May 5, 2024
4 of 5 checks passed
@nvollmar nvollmar deleted the remove-leftover branch May 5, 2024 20:47
@nvollmar
Copy link
Contributor Author

nvollmar commented May 6, 2024

@rebortg this would also apply for Sagitta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rebortg rebortg Awaiting requested review from rebortg rebortg is a code owner

Assignees

@nvollmar nvollmar

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nvollmar @rebortg