Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5809: live-build-config: insmod gzio for vmlinuz kernels on arm64 #468

Merged
merged 1 commit into from
Dec 8, 2023

Conversation

mcbridematt
Copy link
Contributor

Change Summary

Without this, GRUB will report a 'invalid magic' or 'missing UEFI stub' error when loading kernels on arm64.

This change has no effect on x86-64 systems.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T5809

Component(s) name

grub, live-build
(A separate patch may be required for vyos-1x for GRUB when installed to disk, I will check this)

Proposed changes

This change enables the gzio (gzip support) module in grub, allowing it to decompress
gzip compressed kernel images (vmlinuz), which is the default kernel binary on Arm64 systems.
Adding gzio does not have any side effects on x86-64.

How to test

Build a VyOS ISO and boot it on both a arm64 and amd64(x86-64) system.

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Without this, GRUB will report a 'invalid magic' or 'missing UEFI
stub' error when loading kernels on arm64.

This change has no effect on x86-64 systems.
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team December 8, 2023 05:56
@github-actions github-actions bot added the current VyOS rolling release label Dec 8, 2023
@c-po c-po merged commit 7f2d077 into vyos:current Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
current VyOS rolling release
Development

Successfully merging this pull request may close these issues.

2 participants