Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

T7145: updated codeowners list #4339

Merged
merged 2 commits into from
Feb 8, 2025
Merged

T7145: updated codeowners list #4339

merged 2 commits into from
Feb 8, 2025

Conversation

kumvijaya
Copy link
Contributor

Change summary

Updated codeowners

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T7145

Related PR(s)

How to test / Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025 •
edited
Loading

👍
No issues in PR Title / Commit Title

@kumvijaya
Copy link
Contributor Author

@Mergifyio backport sagitta

@kumvijaya
Copy link
Contributor Author

@Mergifyio backport circinus

@kumvijaya
Copy link
Contributor Author

kumvijaya commented Feb 8, 2025 •
edited
Loading

@Mergifyio backport crux

@kumvijaya
Copy link
Contributor Author

kumvijaya commented Feb 8, 2025 •
edited
Loading

@Mergifyio backport equuleus

andamasov
andamasov requested changes Feb 8, 2025
View reviewed changes
Copy link
Member

@andamasov andamasov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to correspond to users in https://github.com/orgs/vyos/teams/reviewers

@kumvijaya kumvijaya requested a review from andamasov February 8, 2025 12:06
@kumvijaya
Copy link
Contributor Author

Need to correspond to users in https://github.com/orgs/vyos/teams/reviewers

Done

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 8, 2025

CI integration ❌ failed!

Details

CI logs

  • CLI Smoketests (no interfaces) ❌ failed
  • CLI Smoketests (interfaces only) 👍 passed
  • Config tests 👍 passed
  • RAID1 tests 👍 passed
  • TPM tests 👍 passed

@andamasov andamasov merged commit 38dacfe into vyos:current Feb 8, 2025
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin

@sarthurdev sarthurdev Awaiting requested review from sarthurdev

@jestabro jestabro Awaiting requested review from jestabro

@sever-sever sever-sever Awaiting requested review from sever-sever

@zdc zdc Awaiting requested review from zdc

@andamasov andamasov Awaiting requested review from andamasov

Assignees

@kumvijaya kumvijaya

Labels
backport bp/circinus bp/crux bp/equuleus bp/sagitta current
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kumvijaya @andamasov @c-po