Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6291: Add LACP related op commands (backport #3389) #3406

Merged
merged 1 commit into from
May 4, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 4, 2024

Change Summary

This PR adds additional op commands for LACP related information. The following commands will be added:

show interfaces bonding lacp detail

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6291

Related PR(s)

Component(s) name

/op-mode-definitions/show-interfaces-bonding.xml.in
New File: /src/op_mode/show_lacp.py

Proposed changes

This change will add the following output for LACP related information:

vyos@vyos:~$ show interfaces bonding lacp detail 
Interface    Members    Mode    Rate    System MAC         Hash
-----------  ---------  ------  ------  -----------------  ------
bond0        eth2       active  slow    16:a4:1f:8b:c0:b3  layer2
bond1                   active  slow    00:00:00:00:00:00  layer2
vyos@vyos:~$ show interfaces bonding bond0 lacp detail 
Interface    Members    Mode    Rate    System MAC         Hash
-----------  ---------  ------  ------  -----------------  ------
bond0        eth2       active  slow    16:a4:1f:8b:c0:b3  layer2
vyos@vyos:~$ show interfaces bonding bond0 lacp neighbors 
Interface    Member    Local ID           Remote ID
-----------  --------  -----------------  -----------------
bond0        eth2      16:a4:1f:8b:c0:b3  00:00:00:00:00:00

Additionally, the show interfaces bonding <bondif> detail command is updated to be run as sudo, allowing for output of valuable information.

How to test

Configure bond interfaces in mode 802.3ad and run new commands:

vyos@vyos# set interfaces bonding bond0 mode 802.3ad 
vyos@vyos# commit

vyos@vyos:~$ show interfaces bonding lacp detail 
Interface    Members    Mode    Rate    System MAC         Hash
-----------  ---------  ------  ------  -----------------  ------
bond0        eth2       active  slow    16:a4:1f:8b:c0:b3  layer2
bond1                   active  slow    00:00:00:00:00:00  layer2

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
    new file: src/op_mode/show_lacp.py

T6291: Add additional op commands for LACP related info. New Command:
show interfaces bonding lacp detail
show interfaces bonding lacp detail
show interfaces bonding lacp neighbors


This is an automatic backport of pull request #3389 done by Mergify.

show interfaces bonding lacp detail
show interfaces bonding <bondif> lacp detail
show interfaces bonding <bondif> lacp neighbors

Co-authored-by: l0crian1 <ryan.claridge13@gmail.com>
(cherry picked from commit 0c2bf31)
@mergify mergify bot mentioned this pull request May 4, 2024
12 tasks
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label May 4, 2024
@sever-sever sever-sever requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team May 4, 2024 15:15
@c-po c-po merged commit bc713d3 into sagitta May 4, 2024
4 of 5 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3389 branch May 4, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

3 participants