Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6287: Config-sync add the ability to configure API port #3384

Merged
merged 1 commit into from
May 1, 2024

Conversation

sever-sever
Copy link
Member

Change Summary

Add the ability to configure the API port if the API on the secondary server works on a non-default port.
The primary node will connect to the configured port for config-sync

set service config-sync secondary port '8443'

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

config-sync

Proposed changes

How to test

Configure the secondary node API port (not default)

set service https api keys id KID key 'foo'
set service https port '8443'

On the primary node, use this port to connect to the secondary API for config-sync:

set service config-sync mode 'load'
set service config-sync secondary address '192.168.122.11'
set service config-sync secondary key 'foo'
set service config-sync secondary port '8443'
set service config-sync section protocols ospf

Change anything under protocol ospf on the primary node

vyos@r4# set protocols ospf area 0 network '192.0.2.0/30'
[edit]
vyos@r4# commit
INFO:vyos_config_sync:Config synchronization: Mode=load, Secondary=192.168.122.11
[edit]
vyos@r4# 

Check on the secondary node protocol ospf

vyos@r1-right# show protocols ospf 
 area 0 {
     network 192.0.2.0/30
 }
[edit]
vyos@r1-right# 

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

Add the ability to configure the API port if the API on the secondary
server works on a non-default port.
The primary node will connect to configured port for config-sync

```
set service config-sync secondary address '192.0.2.11'
set service config-sync secondary port '8443'
```
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and c-po and removed request for a team May 1, 2024 07:10
@dmbaturin dmbaturin merged commit e80e54c into vyos:current May 1, 2024
9 checks passed
@dmbaturin
Copy link
Member

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented May 1, 2024

backport sagitta

✅ Backports have been created

c-po added a commit that referenced this pull request May 4, 2024
T6287: Config-sync add the ability to configure API port (backport #3384)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants