Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect_disconnect: T6261: correction to typo in check_ppp_running (backport #3347) #3348

Merged
merged 1 commit into from
Apr 23, 2024
Merged

connect_disconnect: T6261: correction to typo in check_ppp_running (backport #3347) #3348

merged 1 commit into from
Apr 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 23, 2024

Change Summary

Connect_disconnect: T6261: correction to typo in check_ppp_running function

Changes include:

  1. Replaces "beeing" -> being in print statement for check_ppp_running
  2. Replaces "can not" -> cannot in print statement on lines 61 and 93

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6261

Related PR(s)

Component(s) name

N/A

Proposed changes

N/A

How to test

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • [N/A] I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • [N/A] My change requires a change to the documentation
  • [N/A] I have updated the documentation accordingly
This is an automatic backport of pull request #3347 done by [Mergify](https://mergify.com).

@Giggum @mergify
connect_disconnect: T6261: correction to typo in check_ppp_running fu…
9d90e21 
…nction

Connect_disconnect: T6261: correction to typo in check_ppp_running function

Changes include:
1. Replaces "beeing" -> being in print statement for check_ppp_running
2. Replaces "can not" -> cannot in print statement on lines 61 and 93

(cherry picked from commit 19e0d3b)
@mergify mergify bot mentioned this pull request Apr 23, 2024
Merged
9 tasks
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team April 23, 2024 04:13
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Apr 23, 2024
@c-po c-po added the backport label Apr 23, 2024
@c-po c-po merged commit b734d1f into sagitta Apr 23, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3347 branch April 23, 2024 06:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sever-sever sever-sever sever-sever approved these changes

@c-po c-po c-po approved these changes

@dmbaturin dmbaturin Awaiting requested review from dmbaturin dmbaturin is a code owner automatically assigned from vyos/reviewers

@sarthurdev sarthurdev Awaiting requested review from sarthurdev sarthurdev is a code owner automatically assigned from vyos/reviewers

@zdc zdc Awaiting requested review from zdc zdc is a code owner automatically assigned from vyos/reviewers

@jestabro jestabro Awaiting requested review from jestabro jestabro is a code owner automatically assigned from vyos/reviewers

Assignees
No one assigned
Labels
backport sagitta VyOS 1.4 LTS
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sever-sever @c-po @Giggum