Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T5996: selectively escape and restore single backslashes in config (backport #3035) #3334

Merged
merged 2 commits into from
Apr 20, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 19, 2024

Change Summary

Gory details are summarized in the task, but the short story is that the legacy and modern parser and config output have conflicting practices in handling unescaped backslashes --- the existing filter to allow parsing of legacy output requires a refinement, in order to maintain the occasional use of single backslashes in values.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

vyos@vyos# set interfaces ethernet eth0 description 'fo\o'
[edit]
vyos@vyos# compare
[interfaces ethernet eth0]
+ description "fo\o"

[edit]
vyos@vyos# commit
[edit]
vyos@vyos# run show configuration commands |match desc
set interfaces ethernet eth0 description 'fo\o'
[edit]
vyos@vyos# set interfaces ethernet eth0 description 'fo\\o'
[edit]
vyos@vyos# compare
[interfaces ethernet eth0]
- description "fo\o"
+ description "fo\\o"

[edit]
vyos@vyos# commit
[edit]
vyos@vyos# run show configuration commands |match desc
set interfaces ethernet eth0 description 'fo\\o'

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3035 done by [Mergify](https://mergify.com).

@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Apr 19, 2024
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team April 19, 2024 23:49
@c-po c-po merged commit 563ca81 into sagitta Apr 20, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3035 branch April 20, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

3 participants