Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6214: T6213: change constraint <alpha-numeric-hyphen-underscore-dot.xml.i> (backport #3281) #3293

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 11, 2024

Change Summary

Change constraint alpha-numeric-hyphen-underscore-dot.xml.i in order to not allow string starting with dot character; use such constraint in firewall group definitions.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

firewall

Proposed changes

How to test

vyos@Latest# compare commands 

set firewall group address-group -X_.Y address '198.51.100.3'
set firewall group address-group A.B_C-D address '198.51.100.1'
set firewall group address-group _aB-C. address '198.51.100.2'

[edit]
vyos@Latest# commit
[edit]
vyos@Latest# sudo nft list table ip vyos_filter | grep "set A"
        set A_-X_.Y {
        set A_A.B_C-D {
        set A__aB-C. {
[edit]
vyos@Latest# set firewall group port-group .PG01 port 22

  
  
  Name of firewall group con only contain alpha-numeric letters, hyphen, underscores and dot
  Value validation failed
  Set failed

[edit]
vyos@Latest# 

Smoketest result

Smoketest run during this change:

  • test_firewall.py
  • test_interfaces_pppoe.py
  • test_service_pppoe-server.py
  • test_protocols_bgp.py
  • test_service_dhcp-server.py
  • test_service_dhcpv6-server.py
  • test_pki.py

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3281 done by [Mergify](https://mergify.com).

…xml.i> in order to not allow string starting with dot character; use such constraint in firewall group definitions.

(cherry picked from commit c455a1f)
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro, sever-sever and c-po and removed request for a team April 11, 2024 14:56
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Apr 11, 2024
@c-po c-po merged commit ed3c598 into sagitta Apr 11, 2024
5 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3281 branch April 11, 2024 15:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

4 participants