T6185: simplify marshalling of section and config data for config-sync #3211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Package path/section data in single command containing a tree (dict) of section paths and the accompanying config data. This drops the call to get_config_dict and the need for a list of commands in request.
dmbaturin
approved these changes
Mar 30, 2024
|
Working fine. thanks @jestabro ! |
Merged
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
This adds support for packaging the config-sync data into a single command for the http-api, and avoiding the use of get_config_dict for marshalling, use of which resulted in unnecessary reassembly and a technical annoyance when a section was defined by a leaf node. This is an internal change and does not affect the config-sync interface or definitions.
The section
['system', 'timezone']is added as a demonstration of usefulness.Types of changes
Simplification supporting extension.
Related Task(s)
Related PR(s)
vyos/vyos1x-config#25
vyos/libvyosconfig#13
Component(s) name
Proposed changes
How to test
Smoketest result
Checklist: