Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

op-mode: T6161: Show container details in JSON format (backport #3171) #3176

Merged
merged 1 commit into from
Mar 23, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 23, 2024

Change Summary

Ability to get container details from op-mode in JSON format.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

https://vyos.dev/T6161

Related PR(s)

Component(s) name

op-mode

Proposed changes

Being able to get container information in a parseable format.
This is on-par with other commands such as show configuration json.

I found that the "raw" versions of these commands already existed in the python scripts, so I just used the existing/unused flags.

I also made some assumptions about node types.

Should be backported to sagitta without any issue as it's non-breaking.

How to test

show container json
show container image json
show container network json

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • [?] My change requires a change to the documentation
  • I have updated the documentation accordingly

This is an automatic backport of pull request #3171 done by [Mergify](https://mergify.com).

I made some assumptions about node types, and I expanded the initial
request to also work for networks and containers.

I found that the "raw" versions of these commands already existed in
the python scripts, so I just used the existing flags.

(cherry picked from commit b5d10d1)
@vyosbot vyosbot requested review from a team and dmbaturin and removed request for a team March 23, 2024 16:54
@github-actions github-actions bot added the sagitta VyOS 1.4 LTS label Mar 23, 2024
@c-po c-po merged commit 6e4cd53 into sagitta Mar 23, 2024
4 checks passed
@mergify mergify bot deleted the mergify/bp/sagitta/pr-3171 branch March 23, 2024 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sagitta VyOS 1.4 LTS
Development

Successfully merging this pull request may close these issues.

3 participants