Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T6143: Increase configurable timeout range for service config-sync #3155

Merged
merged 1 commit into from
Mar 20, 2024

Conversation

sever-sever
Copy link
Member

@sever-sever sever-sever commented Mar 20, 2024

Change Summary

The maximum timeout for the service config-sync is 300 seconds (Connection API timeout). It could not be enough for the real massive configurations.
Increase the maximum value to 3600

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe): increase Connection API timeout

Related Task(s)

Related PR(s)

Component(s) name

config-sync

Proposed changes

How to test

set service config-sync secondary address 192.0.2.1
set service config-sync secondary timeout 3600

Smoketest result

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the components SMOKETESTS if applicable
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly

The maximum timeout for the `service config-sync` is 300 seconds
(Connection API timeout). It could not be enough for the real massive
configurations.
Increase the maximum value to 3600

```
set service config-sync secondary address 192.0.2.1
set service config-sync secondary timeout 3600
```
@vyosbot vyosbot requested review from a team, dmbaturin, sarthurdev, zdc, jestabro and c-po and removed request for a team March 20, 2024 11:48
@dmbaturin dmbaturin merged commit a33aacf into vyos:current Mar 20, 2024
8 checks passed
@sever-sever
Copy link
Member Author

@Mergifyio backport sagitta

Copy link
Contributor

mergify bot commented Mar 20, 2024

backport sagitta

✅ Backports have been created

@sever-sever sever-sever changed the title T6143: Increase configuratble timeout range for service config-sync T6143: Increase configurable timeout range for service config-sync Mar 20, 2024
c-po added a commit that referenced this pull request Mar 20, 2024
T6143: Increase configurable timeout range for service config-sync (backport #3155)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

2 participants