ddclient: T5791: Update dynamic dns configuration path for consistency

[indrajitr]

Change Summary

Modify the configuration path to be consistent with the usual dialects of VyoS configuration (wireguard, dns, firewall, etc.)

This would also shorten the configuration path and have a unified treatment for RFC2136-based updates and other 'web-service' based updates.

While at it, add support for per-service web-options. This would allow for probing different external URLs on a per-service basis.

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Code style update (formatting, renaming)
• Refactoring (no functional changes)
• Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
• Other (please describe):

Related Task(s)

• https://vyos.dev/T5791

Related PR(s)

Component(s) name

dns dynamic

Proposed changes

Summary of how the change would look like:

Case 1: Web-based DDNS with address web:
Before:

set service dns dynamic address web web-options url 'https://domains.google.com/checkip'   # Note that this was global
set service dns dynamic address web service cloudflare host-name 'dyn.example.com'
set service dns dynamic address web service cloudflare protocol 'cloudflare'
set service dns dynamic address web service cloudflare zone 'example.com'
set service dns dynamic address web service cloudflare password 'super-secret'
set service dns dynamic address web service cloudflare ip-version 'both'

After:

set service dns dynamic name cloudflare address 'web'
set service dns dynamic name cloudflare web-options url 'https://domains.google.com/checkip'   # Note that this is per-service now
set service dns dynamic name cloudflare host-name 'dyn.example.com'
set service dns dynamic name cloudflare protocol 'cloudflare'
set service dns dynamic name cloudflare zone 'example.com'
set service dns dynamic name cloudflare password 'super-secret'
set service dns dynamic name cloudflare ip-version 'both'

Case 2: Web-based DDNS with address eth6:
Before:

set service dns dynamic address eth6 service cloudflare host-name 'dyn.example.com'
set service dns dynamic address eth6 service cloudflare protocol 'cloudflare'
set service dns dynamic address eth6 service cloudflare zone 'example.com'
set service dns dynamic address eth6 service cloudflare password 'super-secret'
set service dns dynamic address eth6 service cloudflare ip-version 'both'

After:

set service dns dynamic name cloudflare address 'eth6'
set service dns dynamic name cloudflare host-name 'dyn.example.com'
set service dns dynamic name cloudflare protocol 'cloudflare'
set service dns dynamic name cloudflare zone 'example.com'
set service dns dynamic name cloudflare password 'super-secret'
set service dns dynamic name cloudflare ip-version 'both'

Case 3: RFC2136-based DDNS with address web:
Before:

set service dns dynamic address web web-options url 'https://domains.google.com/checkip'    # Note that this was global
set service dns dynamic address web rfc2136 foo host-name 'dyn.example.com'
set service dns dynamic address web rfc2136 foo zone 'example.com'
set service dns dynamic address web rfc2136 foo key '/config/auth/foo.txt'
set service dns dynamic address web rfc2136 foo server 'dns.example.com'

After:

set service dns dynamic name foo address 'web'
set service dns dynamic name cloudflare web-options url 'https://domains.google.com/checkip'   # Note that this is per-service now
set service dns dynamic name foo host-name 'foo.example.com'
set service dns dynamic name foo protocol 'nsupdate'             # Note that this needs to be configured now, just like other protocols
set service dns dynamic name foo zone 'example.com'
set service dns dynamic name foo key '/config/auth/foo.txt'     # Note that `nsupdate` needs `key` instead of `password`
set service dns dynamic name foo server 'dns.example.com'

How to test

Please see above

Smoketest result

vyos@vyos15e:~$ python3 /usr/libexec/vyos/tests/smoke/cli/test_service_dns_dynamic.py
test_01_dyndns_service_standard (__main__.TestServiceDDNS.test_01_dyndns_service_standard) ... 
"zone" is not supported for Dynamic DNS service "freedns" with protocol
"freedns"


"ttl" is not supported for Dynamic DNS service "freedns" with protocol
"freedns"


"ttl" is not supported for Dynamic DNS service "zoneedit" with protocol
"zoneedit1"


"ttl" is not supported for Dynamic DNS service "zoneedit" with protocol
"zoneedit1"

ok
test_02_dyndns_service_ipv6 (__main__.TestServiceDDNS.test_02_dyndns_service_ipv6) ... 
"expiry-time" must be greater than "wait-time" for Dynamic DNS service
"dynv6"

ok
test_03_dyndns_service_dual_stack (__main__.TestServiceDDNS.test_03_dyndns_service_dual_stack) ... 
Both IPv4 and IPv6 at the same time is not supported for Dynamic DNS
service "google" with protocol "googledomains"

ok
test_04_dyndns_rfc2136 (__main__.TestServiceDDNS.test_04_dyndns_rfc2136) ... ok
test_05_dyndns_hostname (__main__.TestServiceDDNS.test_05_dyndns_hostname) ... ok
test_06_dyndns_web_options (__main__.TestServiceDDNS.test_06_dyndns_web_options) ... 
"web-options" is applicable only when using HTTP(S) web request to
obtain the IP address

ok
test_07_dyndns_vrf (__main__.TestServiceDDNS.test_07_dyndns_vrf) ... ok

----------------------------------------------------------------------
Ran 7 tests in 286.257s

OK

Checklist:

• I have read the CONTRIBUTING document
• I have linked this PR to one or more Phabricator Task(s)
• I have run the components SMOKETESTS if applicable
• My commit headlines contain a valid Task id
• My change requires a change to the documentation
• I have updated the documentation accordingly