Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update winit to 0.13.1 #953

Merged
merged 2 commits into from
Jun 5, 2018
Merged

Conversation

branan
Copy link
Contributor

@branan branan commented Apr 26, 2018

Winit 0.13.0 has some fixes for window management on X11 that avoid some messy behavior with Vulkan surfaces (see rust-windowing/winit#434).

@branan
Copy link
Contributor Author

branan commented Apr 26, 2018

It might be worthwhile to hold off on this until rust-windowing/winit#484 is merged and released. Vulkano could then pin to 0.13.1 in order to avoid its users having to manually run cargo update for x11-dl 0.17.5

@branan branan force-pushed the update_winit_0.13 branch from e4c7d7d to 077bed3 Compare April 27, 2018 22:15
@branan branan changed the title Update winit to 0.13.0 Update winit to 0.13.1 Apr 27, 2018
@branan
Copy link
Contributor Author

branan commented Apr 27, 2018

Updated this to point to Winit 0.13.1 to pull in the x11-dl dependency fix

@francesca64
Copy link

winit 0.14.0 is out now. No other changes should be required to increase this to 0.14.0.

cocoa should probably be changed to version 0.14 though, since that's the version winit pulls in.

@francesca64
Copy link

...and now we're up to winit 0.15.0. Once again, no other changes needed.

@Abendstolz
Copy link
Contributor

Abendstolz commented Jun 3, 2018

Are there really no more changes needed to update to winit 0.15.0? I tried locally and got

error[E0599]: no method named build_vk_surfacefound for typewinit::WindowBuilder in the current scope

Now I am wondering why (Only change from winit ^0.11.0 right to ^0.15.0)

@rukai
Copy link
Member

rukai commented Jun 3, 2018

You will also need to change the version in the cargo.toml for vulkano-win.

@tomaka
Copy link
Member

tomaka commented Jun 5, 2018

Thanks. This PR is no longer that relevant but it can't hurt to merge it.

@tomaka tomaka merged commit 44530af into vulkano-rs:master Jun 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants