Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configuration upgrade fixes. #4299

Merged
merged 5 commits into from
Mar 18, 2025
Merged

Conversation

demiankatz
Copy link
Member

@demiankatz demiankatz commented Mar 17, 2025

This PR fixes a few upgrade-related issues discovered while releasing 10.1.2:

  • Some type annotations in the VuFind\Config\Upgrade class were incorrect
  • The new granular database configuration logic could get reverted/corrupted by upgrade logic
  • An inappropriate version number check could cause incorrect configurations to get loaded by the upgrade process

Note that I don't believe these problems are actually new to 10.1.2; they likely affected earlier 10.1.x releases as well. I'm not sure why I only ran into them this time, but I think behavior is at least partially dependent on the value you put in the "old version" box on the upgrade page, so I probably just did things slightly differently this time.

@demiankatz demiankatz added this to the 10.1.3 milestone Mar 17, 2025
Copy link
Contributor

@EreMaijala EreMaijala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@demiankatz demiankatz merged commit 94ca9f1 into vufind-org:dev Mar 18, 2025
6 checks passed
@demiankatz demiankatz deleted the config-upgrade-fix branch March 18, 2025 11:12
demiankatz added a commit that referenced this pull request Mar 18, 2025
@demiankatz
Copy link
Member Author

This PR was targeted against the wrong branch; the commit has been backported to release-10.1.

ckaz pushed a commit to finc/vufind that referenced this pull request Mar 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants