Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix screen reader issues in hierarchy tree #4291

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

siiriylonen
Copy link
Contributor

@siiriylonen siiriylonen commented Mar 11, 2025

A couple of noted accessibility issues when using JAWS reader specifically:

On the first element (when entering the tree) it reads:
“Use JawsKey+Alt+M to move to controlled element”
aria-controls seemed to be the cause of this.
Could it be removed?

Also at the end points of hierarchy tree, it unnecessarily reads the disabled button.
Could the whole button be removed?

@EreMaijala
Copy link
Contributor

@siiriylonen The disabled button cannot be removed without it affecting the layout. Perhaps a better solution would be to hide it from screen readers?

Copy link
Member

@demiankatz demiankatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm marking this as "request changes" until @EreMaijala's comment is addressed, just to be sure it doesn't get merged prematurely by accident. :-) Thank you, @siiriylonen!

@demiankatz demiankatz added this to the 11.0 milestone Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants