Refactor "copy to clipboard" button and use it for citations #4289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demiankatz
requested changes
Mar 10, 2025
There was a problem hiding this comment.
Thanks, @ThoWagen -- haven't done any hands-on testing yet, but see below for a few minor comments from a read-through of the code.
themes/bootstrap5/templates/Helpers/copy-to-clipboard-button.phtml
Outdated
Show resolved
Hide resolved
themes/bootstrap5/templates/RecordDriver/DefaultRecord/toolbar.phtml
Outdated
Show resolved
Hide resolved
demiankatz
requested changes
Mar 11, 2025
module/VuFind/src/VuFind/View/Helper/Bootstrap5/CopyToClipboardButton.php
Outdated
Show resolved
Hide resolved
demiankatz
approved these changes
Mar 11, 2025
ckaz
pushed a commit
to finc/vufind
that referenced
this pull request
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR was to add "copy to clipboard" buttons to the citations.
At the same time the "copy to clipboard" buttons got refactored (removal of jQuery, JavaScript moved into a .js file, success/error message as popover and new design for permalinks).