fix(MdProgressSpinner): improve transition #1946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for PR! But after this PR custom value for spinner is broken, can you please look at it? |
|
I think this is broken since the previous PR. I'm not 100% sure but If I understand the code correctly. The If I add a watcher the same as What do you think? |
|
Yeah you are true, its broken before too. Yes adding watcher for mdValue should fix that. |
|
I have updated my PR.
|
marcosmoura
added a commit
that referenced
this pull request
May 12, 2019
* origin: fix(MdProgressSpinner): improve transition (#1946)
marcosmoura
added a commit
that referenced
this pull request
May 12, 2019
* origin: (80 commits) docs: remove wrong text-shadow docs: add referal code fix(MdProgressSpinner): improve transition (#1946) chore: upgrade deps docs: fix 2 wrong property names with autocomplete docs (#2006) fix(MdTable): undefined table sorting #1906 (#2012) docs: fix dynamic tooltip text to show bottom instead of top (#2013) refactor(MdDatepicker): upgrade date-fns (#2037) fix(MdDatepicker): positioning when used inside flex container (#2036) fix(MdSelect): infinite loop error, when no v-model provided (#2035) fix(MdApp): normalized component's tag before checking to match slot … (#1994) chore: some misspellings in config.js (#1986) fixFixed non unique ids on MdSelect (#2001) fix(MdInput): invert password on-off icons (#2008) test: fix test selectors for checkbox and switch (#2009) docs: add default theme as a suggestion (#2043) Fixed md-wave transition (#2034) fix(MdRipple): fixed missing ripple effect (#2059) docs: add codefund ads and remove old sponsors fix(MdSvgLoader): svg loader for invalid / missing mimetype (#1942) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add explicit transition duration
It seems Vue cannot detect animation/transition end because of infinite animation at https://github.com/vuematerial/vue-material/blob/dev/src/components/MdProgress/MdProgressSpinner/MdProgressSpinner.vue#L260.
Split enter and leave animation in determinate mode
Use reverse animation for leave state instead.
Fix #1935