Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(MdRipple): clear immediately #1506

Merged
merged 4 commits into from
Feb 14, 2018
Merged

fix(MdRipple): clear immediately #1506

merged 4 commits into from
Feb 14, 2018

Conversation

VdustR
Copy link
Member

@VdustR VdustR commented Feb 13, 2018

  • clear wave immediately instead of debounce delay.

  • <transition group> make MutationObserver callback many times by one click, and it will cause page dead with CPU leakage.
    This could reproduce with this reproduction: [MdTabs] content length calculations #1500 (comment) with 1.0.0-beta-8.
    I can't find a way to configure the <transition group> to work as fine as <transition>. The solution for now is using <transition> and make waves act like old single ripple with animating.

related to #1419, #1500

@VdustR
Copy link
Member Author

VdustR commented May 9, 2018

fix #1700

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants