Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MdRipple] does not work on buttons in Firefox #1461

Closed
anckaertr opened this issue Jan 31, 2018 · 2 comments · Fixed by #1468
Closed

[MdRipple] does not work on buttons in Firefox #1461

anckaertr opened this issue Jan 31, 2018 · 2 comments · Fixed by #1468
Labels

Comments

@anckaertr
Copy link

Steps to reproduce

simply add a button on a page.

Which browser?

Firefox 57.x, Firefox 58.x

What is expected?

the ripple effect

What is actually happening?

Nothing

@Samuell1 Samuell1 added the bug label Jan 31, 2018
@Samuell1 Samuell1 changed the title Ripple does not work on buttons in Firefox [MdRipple] does not work on buttons in Firefox Jan 31, 2018
@Samuell1
Copy link
Member

Doesnt work only if md-button element is button because elements inside button doesnt have events.

@Soletiq
Copy link

Soletiq commented Feb 12, 2018

+1 please fix

marcosmoura pushed a commit that referenced this issue Feb 20, 2018
* fix(MdButton): Ripple for firefox

fix #1461

* refactor(MdButton): new computed `rippleWorks`

* refactor(MdButton): active ripple by props instead of method call

* refactor(MdButton): remove unnecessary events
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants