fix domProps unset for v-html (fix #4107)

vuejs · Nov 4, 2016 · d0afcd3 · d0afcd3
1 parent fa16b12
commit d0afcd3
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/src/core/vdom/patch.js b/src/core/vdom/patch.js
@@ -78,7 +78,10 @@ export function createPatchFunction (backend) {
 
   function removeElement (el) {
     const parent = nodeOps.parentNode(el)
-    nodeOps.removeChild(parent, el)
+    // element may have already been removed due to v-html
+    if (parent) {
+      nodeOps.removeChild(parent, el)
+    }
   }
 
   function createElm (vnode, insertedVnodeQueue, nested) {

diff --git a/src/platforms/web/runtime/modules/dom-props.js b/src/platforms/web/runtime/modules/dom-props.js
@@ -17,7 +17,7 @@ function updateDOMProps (oldVnode: VNodeWithData, vnode: VNodeWithData) {
 
   for (key in oldProps) {
     if (props[key] == null) {
-      elm[key] = undefined
+      elm[key] = ''
     }
   }
   for (key in props) {

diff --git a/test/unit/modules/vdom/modules/dom-props.spec.js b/test/unit/modules/vdom/modules/dom-props.spec.js
@@ -22,7 +22,7 @@ describe('vdom domProps module', () => {
     const vnode2 = new VNode('a', { domProps: {}})
     patch(null, vnode1)
     const elm = patch(vnode1, vnode2)
-    expect(elm.src).toBeUndefined()
+    expect(elm.src).toBe('')
   })
 
   it('should initialize the elements value to zero', () => {