Add missing string handler in v-for (#4499)

Fix #4497
vuejs · Dec 16, 2016 · 974247f · 974247f · bfanger · Dec 25, 2016
1 parent 34333ca
commit 974247f
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 1 deletion.
diff --git a/src/core/instance/render.js b/src/core/instance/render.js
@@ -178,7 +178,7 @@ export function renderMixin (Vue: Class<Component>) {
     render: () => VNode
   ): ?Array<VNode> {
     let ret: ?Array<VNode>, i, l, keys, key
-    if (Array.isArray(val)) {
+    if (Array.isArray(val) || typeof val === 'string') {
       ret = new Array(val.length)
       for (i = 0, l = val.length; i < l; i++) {
         ret[i] = render(val[i], i)

diff --git a/test/unit/features/directives/for.spec.js b/test/unit/features/directives/for.spec.js
@@ -428,4 +428,22 @@ describe('Directive v-for', () => {
       expect(vm.$el.textContent).toMatch(/\s+foo\s+bar\s+/)
     }).then(done)
   })
+
+  it('strings', done => {
+    const vm = new Vue({
+      data: {
+        text: 'foo'
+      },
+      template: `
+        <div>
+          <span v-for="letter in text">{{ letter }}.</span
+        </div>
+      `
+    }).$mount()
+    expect(vm.$el.textContent).toMatch('f.o.o.')
+    vm.text += 'bar'
+    waitForUpdate(() => {
+      expect(vm.$el.textContent).toMatch('f.o.o.b.a.r.')
+    }).then(done)
+  })
 })